From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572Ab1AQOxr (ORCPT ); Mon, 17 Jan 2011 09:53:47 -0500 Received: from hapkido.dreamhost.com ([66.33.216.122]:46452 "EHLO hapkido.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143Ab1AQOxq (ORCPT ); Mon, 17 Jan 2011 09:53:46 -0500 Subject: Re: [PATCH] input: ct82710c: return proper error code for ct82c710_open From: Davidlohr Bueso To: Dmitry Torokhov Cc: LKML , "linux-serial@vger.kernel.org" In-Reply-To: <20110117082251.GB22802@core.coreip.homeip.net> References: <1294940150.2200.4.camel@offworld> <20110117082251.GB22802@core.coreip.homeip.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 17 Jan 2011 09:43:25 -0300 Message-ID: <1295268205.2130.0.camel@offworld> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-01-17 at 00:22 -0800, Dmitry Torokhov wrote: > On Thu, Jan 13, 2011 at 02:35:50PM -0300, Davidlohr Bueso wrote: > > From: Davidlohr Bueso > > > > If request_irq() fails we should return the proper error instead of -1. > > > > Signed-off-by: Davidlohr Bueso > > Will apply, thank you. You don't really have the device, do you? > No, I don't have that device, but looks trivial enough to be compile-tested only. Thanks. > Thanks. >