From: Peter Zijlstra <peterz@infradead.org>
To: Paul Turner <pjt@google.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Mike Galbraith <efault@gmx.de>, Nick Piggin <npiggin@kernel.dk>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [wake_afine fixes/improvements 1/3] sched: update effective_load() to use global share weights
Date: Mon, 17 Jan 2011 15:20:35 +0100 [thread overview]
Message-ID: <1295274035.30950.122.camel@laptop> (raw)
In-Reply-To: <1295273497.30950.119.camel@laptop>
On Mon, 2011-01-17 at 15:11 +0100, Peter Zijlstra wrote:
>
> > + if (lw > 0 && wl < lw)
> > + wl = (wl * tg->shares) / lw;
> > + else
> > + wl = tg->shares;
>
> OK, so this computes the new load for this cpu, by taking the
> appropriate proportion of tg->shares, it clips on large wl, and does
> something funny for !lw -- on purpose?
D'0h, when !lw, the tg is empty and we don't care what happens since it
won't get scheduled anyway..
Ok, very nice, applied!
next prev parent reply other threads:[~2011-01-17 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 1:57 [wake_afine fixes/improvements 0/3] Introduction Paul Turner
2011-01-15 1:57 ` [wake_afine fixes/improvements 1/3] sched: update effective_load() to use global share weights Paul Turner
2011-01-17 14:11 ` Peter Zijlstra
2011-01-17 14:20 ` Peter Zijlstra [this message]
2011-01-18 19:04 ` [tip:sched/urgent] sched: Update " tip-bot for Paul Turner
2011-01-15 1:57 ` [wake_afine fixes/improvements 2/3] sched: clean up task_hot() Paul Turner
2011-01-17 14:14 ` Peter Zijlstra
2011-01-18 21:52 ` Paul Turner
2011-01-15 1:57 ` [wake_afine fixes/improvements 3/3] sched: introduce sched_feat(NO_HOT_AFFINE) Paul Turner
2011-01-15 14:29 ` [wake_afine fixes/improvements 0/3] Introduction Mike Galbraith
2011-01-15 19:29 ` Paul Turner
2011-01-15 21:34 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295274035.30950.122.camel@laptop \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@kernel.dk \
--cc=pjt@google.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox