From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: safford@watson.ibm.com, David Safford <safford@us.ibm.com>,
jj@chaosbits.net, dhowells@redhat.com, jmorris@namei.org,
keyrings@linux-nfs.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] trusted-keys: small cleanup
Date: Tue, 18 Jan 2011 06:42:28 -0500 [thread overview]
Message-ID: <1295350948.3426.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1295350109.3426.29.camel@localhost.localdomain>
On Tue, 2011-01-18 at 06:28 -0500, Mimi Zohar wrote:
> On Tue, 2011-01-18 at 20:03 +0900, Tetsuo Handa wrote:
> > Mimi Zohar wrote:
> > > > > va_end(argp);
> > > > > - ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > > > > + if (!ret)
> > > > > + ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > > > > if (!ret)
> > >
> > > Change the second '(!ret)' here, the crypto_shash_file() return code
> > > test, from '(!ret)' to '(ret < 0)', like the other crypto_shash_file()
> > > tests.
> >
> > Did you mean changing from
> >
> > if (!ret)
> > ret = crypto_shash_final(&sdesc->shash, paramdigest);
> >
> > to
> >
> > if (ret < 0)
> > ret = crypto_shash_final(&sdesc->shash, paramdigest);
> >
> > (i.e. invert the condition)?
>
> Wrong '(!ret)'. Instead of:
> va_end(argp);
> if (!ret)
> ret = crypto_shash_final(&sdesc->shash, paramdigest);
> if (!ret)
>
> do:
> va_end(argp);
> if (!ret)
> ret = crypto_shash_final(&sdesc->shash, paramdigest);
> if (ret < 0)
>
> > I'm confused. Would you make the patch by yourself?
>
> It's only for consistency, not that important.
>
> thanks,
>
> Mimi
James, the original patch is fine as is.
thanks,
Mimi
next prev parent reply other threads:[~2011-01-18 11:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 20:07 [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() so we always kfree() and remember to call va_end() Jesper Juhl
2011-01-14 13:28 ` David Safford
2011-01-14 13:45 ` [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() so wealways " Tetsuo Handa
2011-01-14 14:07 ` Tetsuo Handa
2011-01-15 0:58 ` Tetsuo Handa
2011-01-16 14:04 ` Jesper Juhl
2011-01-17 0:39 ` [PATCH 1/3] trusted-keys: another free memory bugfix Tetsuo Handa
2011-01-17 0:41 ` [PATCH 2/3] trusted-keys: check for NULL before using it Tetsuo Handa
2011-01-17 0:44 ` [PATCH 3/3] trusted-keys: avoid scattring va_end() Tetsuo Handa
2011-01-17 9:39 ` David Howells
2011-01-17 18:36 ` Jesper Juhl
2011-01-17 21:06 ` Mimi Zohar
2011-01-18 1:39 ` [PATCH 3/3] trusted-keys: small cleanup Tetsuo Handa
2011-01-18 9:26 ` Mimi Zohar
2011-01-18 11:03 ` Tetsuo Handa
2011-01-18 11:28 ` Mimi Zohar
2011-01-18 11:42 ` Mimi Zohar [this message]
2011-01-17 9:34 ` [PATCH 2/3] trusted-keys: check for NULL before using it David Howells
2011-01-17 18:35 ` Jesper Juhl
2011-01-17 21:02 ` Mimi Zohar
2011-01-17 9:33 ` [PATCH 1/3] trusted-keys: another free memory bugfix David Howells
2011-01-17 18:34 ` Jesper Juhl
2011-01-17 21:01 ` Mimi Zohar
2011-01-18 22:55 ` James Morris
2011-01-14 13:31 ` [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() so we always kfree() and remember to call va_end() David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295350948.3426.36.camel@localhost.localdomain \
--to=zohar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=jj@chaosbits.net \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=safford@us.ibm.com \
--cc=safford@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox