From: Peter Zijlstra <peterz@infradead.org>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: samu.p.onkalo@nokia.com, mingo@elte.hu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
tglx <tglx@linutronix.de>
Subject: Re: Bug in scheduler when using rt_mutex
Date: Wed, 19 Jan 2011 11:38:18 +0100 [thread overview]
Message-ID: <1295433498.30950.1482.camel@laptop> (raw)
In-Reply-To: <1295430276.30950.1414.camel@laptop>
On Wed, 2011-01-19 at 10:44 +0100, Peter Zijlstra wrote:
> +static void
> +switched_from_fair(struct rq *rq, struct task_struct *p, int running)
> +{
> + struct sched_entity *se = &p->se;
> + struct cfs_rq *cfs_rq = cfs_rq_of(se);
> +
> + if (!se->on_rq && p->state != TASK_RUNNING)
> + se->vruntime -= cfs_rq->min_vruntime;
> +}
> +
> /*
> * We switched to the sched_fair class.
> */
> -static void switched_to_fair(struct rq *rq, struct task_struct *p,
> - int running)
> +static void
> +switched_to_fair(struct rq *rq, struct task_struct *p, int running)
> {
> + struct sched_entity *se = &p->se;
> + struct cfs_rq *cfs_rq = cfs_rq_of(se);
> +
> + if (se->on_rq && cfs_rq->curr != se)
> + __dequeue_entity(cfs_rq, se);
> +
> + se->vruntimea += cfs_rq->min_vruntime;
> +
> + if (se->on_rq && cfs_rq->curr != se)
> + __enqueue_entity(cfs_rq, se);
> +
> /*
> * We were most likely switched from sched_rt, so
> * kick off the schedule if running, otherwise just see
Hrm, I think the to bit is not needed with the from thing in place, the
enqueue from _setprio will already have added min_vruntime
next prev parent reply other threads:[~2011-01-19 10:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 14:42 Bug in scheduler when using rt_mutex Onkalo Samu
2011-01-17 15:00 ` Peter Zijlstra
2011-01-17 15:15 ` samu.p.onkalo
2011-01-17 15:28 ` Peter Zijlstra
2011-01-17 16:00 ` Peter Zijlstra
2011-01-18 8:23 ` Onkalo Samu
2011-01-18 8:59 ` Yong Zhang
2011-01-18 13:35 ` Peter Zijlstra
2011-01-18 14:25 ` Onkalo Samu
2011-01-19 2:38 ` Yong Zhang
2011-01-19 3:43 ` Mike Galbraith
2011-01-19 4:35 ` Yong Zhang
2011-01-19 5:40 ` Mike Galbraith
2011-01-19 6:09 ` Yong Zhang
2011-01-19 6:37 ` Mike Galbraith
2011-01-19 7:19 ` Ingo Molnar
2011-01-19 7:41 ` Mike Galbraith
2011-01-19 9:44 ` Peter Zijlstra
2011-01-19 10:38 ` Peter Zijlstra [this message]
2011-01-19 11:30 ` Peter Zijlstra
2011-01-19 12:58 ` Onkalo Samu
2011-01-19 13:13 ` Onkalo Samu
2011-01-19 13:30 ` Peter Zijlstra
2011-01-20 4:18 ` Yong Zhang
2011-01-20 4:27 ` Yong Zhang
2011-01-20 5:32 ` Yong Zhang
2011-01-20 4:59 ` Mike Galbraith
2011-01-20 5:30 ` Yong Zhang
2011-01-20 6:12 ` Mike Galbraith
2011-01-20 7:06 ` Yong Zhang
2011-01-20 8:37 ` Mike Galbraith
2011-01-20 9:07 ` Yong Zhang
2011-01-20 10:07 ` Mike Galbraith
2011-01-21 11:08 ` Peter Zijlstra
2011-01-21 12:24 ` Yong Zhang
2011-01-21 13:40 ` Peter Zijlstra
2011-01-21 15:03 ` Yong Zhang
2011-01-21 15:10 ` Peter Zijlstra
2011-01-21 13:15 ` Yong Zhang
2011-01-20 7:07 ` Onkalo Samu
2011-01-21 6:25 ` Onkalo Samu
2011-01-20 3:10 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295433498.30950.1482.camel@laptop \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=samu.p.onkalo@nokia.com \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox