From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561Ab1ASXLJ (ORCPT ); Wed, 19 Jan 2011 18:11:09 -0500 Received: from mail.perches.com ([173.55.12.10]:3204 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844Ab1ASXLH (ORCPT ); Wed, 19 Jan 2011 18:11:07 -0500 Subject: Re: [PATCH] vsprintf: Neaten %pK kptr_restrict, save a bit of code space From: Joe Perches To: Andrew Morton Cc: Dan Rosenberg , linux-kernel@vger.kernel.org In-Reply-To: <20110119145024.353ef8a1.akpm@linux-foundation.org> References: <1294950072.4114.172.camel@Joe-Laptop> <20110119145024.353ef8a1.akpm@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 19 Jan 2011 15:11:02 -0800 Message-ID: <1295478662.1952.45.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-01-19 at 14:50 -0800, Andrew Morton wrote: > On Thu, 13 Jan 2011 12:21:12 -0800 > Joe Perches wrote: > > If kptr restrictions are on, just set the passed pointer to NULL. > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > > + if (!((kptr_restrict == 0) || > > + (kptr_restrict == 1 && > > + has_capability_noaudit(current, CAP_SYSLOG)))) > > + ptr = NULL; > > + break; > This hurts my brain. Does it work? Some say mentally challenging puzzles help deter/delay onset of cognitive decline/Alzheimer's. See: www.dakim.com A mentally less challenging perhaps cleaner form is: if (kptr_restrict == 0) break; if (kptr_restrict == 1 && has_capability_noaudit(current, CAP_SYSLOG)) break; ptr = NULL; break; Your choice. ;)