From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755242Ab1ATE7E (ORCPT ); Wed, 19 Jan 2011 23:59:04 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48079 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100Ab1ATE7C (ORCPT ); Wed, 19 Jan 2011 23:59:02 -0500 Subject: Re: [patch 32/37] parisc: Use generic irq Kconfig From: James Bottomley To: Thomas Gleixner Cc: LKML , Linux-Arch , Andrew Morton , Ingo Molnar , Kyle McMartin In-Reply-To: References: <20110119205258.462759212@linutronix.de> <20110119210840.424269590@linutronix.de> <1295474722.10978.43.camel@mulgrave.site> Content-Type: text/plain; charset="UTF-8" Date: Wed, 19 Jan 2011 22:58:58 -0600 Message-ID: <1295499538.12205.670.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.30.1.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-01-19 at 23:16 +0100, Thomas Gleixner wrote: > On Wed, 19 Jan 2011, James Bottomley wrote: > > > On Wed, 2011-01-19 at 21:49 +0000, Thomas Gleixner wrote: > > > plain text document attachment (parisc-use-generic-irq-Kconfig.patch) > > > No functional change. > > > > Not quite true ... you take out GENERIC_HARDIRQS but select > > HAVE_GENERIC_HARDIRQS ... is that right? > > HAVE_GENERIC_HARDIRQS enables the Kconfig file in kernel/irq/ Ah, OK, thanks. > > > Signed-off-by: Thomas Gleixner > > > Cc: Kyle McMartin > > > > Plus, it doesn't apply: > > > > Hunk #1 FAILED at 12. > > Hunk #2 FAILED at 65. > > 2 out of 2 hunks FAILED -- saving rejects to file > > arch/parisc/Kconfig.rej > > > > It looks like it was made before we did our generic irq conversion in > > the 2.6.36 merge window. > > You meant 38 window :) No ... it went in when Kyle was maintainer ... so that's at least 37 or before. > Patch is against 38-rc1 but depends on [patch > 24/37] genirq: Remove __do_IRQ in this very same series. Ah, great ... missed that one. With this it all seems to work, so you can add my ack to the parisc piece. James