From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090Ab1AUCZe (ORCPT ); Thu, 20 Jan 2011 21:25:34 -0500 Received: from mail.perches.com ([173.55.12.10]:3235 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315Ab1AUCZc (ORCPT ); Thu, 20 Jan 2011 21:25:32 -0500 Subject: Re: [PATCH 0/7] Nexus One Support From: Joe Perches To: Daniel Walker Cc: Dima Zavin , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org In-Reply-To: <1295575123.9236.54.camel@m0nster> References: <1295555565-21563-1-git-send-email-dwalker@codeaurora.org> <1295571359.9236.53.camel@m0nster> <1295574085.4096.6.camel@Joe-Laptop> <1295575123.9236.54.camel@m0nster> Content-Type: text/plain; charset="UTF-8" Date: Thu, 20 Jan 2011 18:25:30 -0800 Message-ID: <1295576730.4096.24.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-01-20 at 17:58 -0800, Daniel Walker wrote: > On Thu, 2011-01-20 at 17:41 -0800, Joe Perches wrote: > > On Thu, 2011-01-20 at 16:55 -0800, Daniel Walker wrote: > > > On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote: > > > > You are not the author of any of these patches. Where are the author > > > > attributions for the team that actually wrote this code? > > > In the commit text.. The author field is used to denote who authored the > > > commit, which in this case is me. > > You have that wrong. > > Author and Committer are different git fields. > > http://www.kernel.org/pub/software/scm/git/docs/user-manual.html > > > > * an author: The name of the person responsible for this change, > > together with its date. > > * a committer: The name of the person who actually created the > > commit, with the date it was done. This may be different from > > the author, for example, if the author was someone who wrote a > > patch and emailed it to the person who used it to create the > > commit. > I'm not even sure how to make these different, but in this case it > doesn't matter because the "committer" as you defined it above is more > than one person .. Not really, no. The authors may be different, but the first git committer of the patch is different. The committer is the person that does a git commit either directly with git commit or git am. If a git tree is pulled by someone else, the initial committer name remains on the commit. You should keep the original patch author names and add your own "Signed-off-by:" and not claim authorship of the patches themselves. cheers, Joe