From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069Ab1AUSfH (ORCPT ); Fri, 21 Jan 2011 13:35:07 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:5807 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283Ab1AUSfF (ORCPT ); Fri, 21 Jan 2011 13:35:05 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6233"; a="71413657" Subject: Re: [PATCH 0/7] Nexus One Support From: Daniel Walker To: Jesse Barnes Cc: Joe Perches , Dima Zavin , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davidb@codeaurora.org In-Reply-To: <20110121102740.7f7a57f9@jbarnes-desktop> References: <1295555565-21563-1-git-send-email-dwalker@codeaurora.org> <1295571359.9236.53.camel@m0nster> <1295574085.4096.6.camel@Joe-Laptop> <1295575123.9236.54.camel@m0nster> <1295576730.4096.24.camel@Joe-Laptop> <1295624801.19880.13.camel@m0nster> <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <20110121102740.7f7a57f9@jbarnes-desktop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 21 Jan 2011 10:35:06 -0800 Message-ID: <1295634906.19880.34.camel@m0nster> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-01-21 at 10:27 -0800, Jesse Barnes wrote: > Ok, then I'm sorry for jumping the gun. The changelogs made the > changes sound more trivial ("slight modifications and cleanup"); and > those would only justify a small [] text near the s-o-b lines. But if > they're larger, maybe you should expand on the text and include the > original authorship like Christoph suggested (or use the original > author for patches where the changes really were trivial). yeah, I didn't really think about that line when I wrote it.. It should just says "Base on code from Google." I was just trying to give them some credit. I've done changes like your suggesting (923a081c72fa2dccb7ea7070bd8e0f4dc99ceff8) so I'm not a novice to this. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.