From: "L. Alberto Giménez" <agimenez@sysvalve.es>
To: linux-kernel@vger.kernel.org
Cc: "L. Alberto Giménez" <agimenez@sysvalve.es>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Joe Perches" <joe@perches.com>,
"David S. Miller" <davem@davemloft.net>,
"Florian Mickler" <florian@mickler.org>,
"Stephen Hemminger" <shemminger@vyatta.com>,
"Wolfram Sang" <w.sang@pengutronix.de>
Subject: [PATCH] get_maintainer.pl: Add support to match arbitrary text
Date: Tue, 25 Jan 2011 00:32:29 +0100 [thread overview]
Message-ID: <1295911951-12615-1-git-send-email-agimenez@sysvalve.es> (raw)
Extend the usage of the K section in the MAINTAINERS file to support matching
regular expressions with the content that precedes the patch (delimited by three
dashes "---").
The change enables the get_maintainer.pl script to get maintainers based on
arbitrary text that may precede the patch itself (for example, the commit
message or mail headers generated by git-format-patch)
Thanks to Jesper Juhl to point me that trivial patches should be CC'd to Jiri.
The idea is that the get_maintainer.pl can detect such situations and add the
additional email addresses and let the MAINTAINERS file handle who should get
copies of what.
Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
---
MAINTAINERS | 1 +
scripts/get_maintainer.pl | 12 +++++++++++-
2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cf0f3a5..c1e33ac 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6145,6 +6145,7 @@ TRIVIAL PATCHES
M: Jiri Kosina <trivial@kernel.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
S: Maintained
+K: ^Subject:.*\[(?i)trivial\].*
TTY LAYER
M: Greg Kroah-Hartman <gregkh@suse.de>
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 139e0ff..63d4d90 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -420,6 +420,11 @@ foreach my $file (@ARGV) {
open(my $patch, "< $file")
or die "$P: Can't open $file: $!\n";
+
+ # We can add arbitrary information before the patch itself (commit message,
+ # mail headers,... This allows us to match arbitrary keywords agains any
+ # part of a git-format-patch generated file (subject tags, etc...)
+ my $in_patch = 0;
while (<$patch>) {
my $patch_line = $_;
if (m/^\+\+\+\s+(\S+)/) {
@@ -432,9 +437,14 @@ foreach my $file (@ARGV) {
if ($email_git_blame) {
push(@range, "$lastfile:$1:$2");
}
+ } elsif (not $in_patch and m/^---/) {
+ # enter "patch area": keywords matched only on changed lines
+ $in_patch = 1;
} elsif ($keywords) {
foreach my $line (keys %keyword_hash) {
- if ($patch_line =~ m/^[+-].*$keyword_hash{$line}/x) {
+ my $change_hook = $in_patch ? "^[+-].*" : "";
+
+ if ($patch_line =~ m/^${change_hook}$keyword_hash{$line}/x) {
push(@keyword_tvi, $line);
}
}
--
1.7.4.rc0.5.gf2665
next reply other threads:[~2011-01-24 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 23:32 L. Alberto Giménez [this message]
2011-01-24 23:53 ` [PATCH] get_maintainer.pl: Add support to match arbitrary text Joe Perches
2011-01-25 0:25 ` L. Alberto Giménez
2011-01-25 14:08 ` [PATCH] get_maintainer.pl: Allow "K:" pattern tests to match non-patch text Joe Perches
2011-01-25 18:44 ` L. Alberto Giménez
2011-01-25 18:58 ` Joe Perches
2011-01-26 12:23 ` "L. Alberto Giménez"
2011-01-25 14:23 ` [PATCH] get_maintainer.pl: Add support to match arbitrary text Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295911951-12615-1-git-send-email-agimenez@sysvalve.es \
--to=agimenez@sysvalve.es \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=florian@mickler.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox