From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] ASoC: Fix codec device id format used by some dai_links
Date: Tue, 25 Jan 2011 11:55:12 +0000 [thread overview]
Message-ID: <1295956512.3322.74.camel@odin> (raw)
In-Reply-To: <1295903363-4433-1-git-send-email-lars@metafoo.de>
On Mon, 2011-01-24 at 22:09 +0100, Lars-Peter Clausen wrote:
> The id part of an I2C device name is created with the "%d-%04x" format string.
>
> So for example for an I2C device which is connected to the adapter with the id 0
> and has its address set to 0x1a the id part of the devices name would be
> "0-001a".
>
> Currently some sound board drivers have the id part the codec_name field of
> their dai_link structures set as if it had been created by a "%d-0x%x" format
> string. For example "0-0x1a" instead of "0-001a".
>
> As a result there is no match between the codec device and the dai_link and no
> sound card is instantiated.
>
> This patch fixes it.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
Both
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-01-25 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 21:09 [PATCH 1/2 v2] ASoC: Fix codec device id format used by some dai_links Lars-Peter Clausen
2011-01-24 21:12 ` [PATCH 2/2] SoC: Samsung: Fix outdated cpu_dai_name for s3c24xx i2s Lars-Peter Clausen
2011-01-25 1:44 ` [alsa-devel] " Jassi Brar
2011-01-25 11:55 ` Liam Girdwood [this message]
2011-01-25 13:39 ` [PATCH 1/2 v2] ASoC: Fix codec device id format used by some dai_links Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295956512.3322.74.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox