From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753371Ab1AYMPa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Jan 2011 07:15:30 -0500
Received: from bombadil.infradead.org ([18.85.46.34]:51262 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751980Ab1AYMP2 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Jan 2011 07:15:28 -0500
Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 5/20]  5: Uprobes:
 register/unregister probes.
From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
        Linux-mm <linux-mm@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Christoph Hellwig <hch@infradead.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        SystemTap <systemtap@sources.redhat.com>,
        Jim Keniston <jkenisto@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, LKML <linux-kernel@vger.kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
In-Reply-To: <20101216095817.23751.76989.sendpatchset@localhost6.localdomain6>
References: <20101216095714.23751.52601.sendpatchset@localhost6.localdomain6>
	 <20101216095817.23751.76989.sendpatchset@localhost6.localdomain6>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Tue, 25 Jan 2011 13:15:45 +0100
Message-ID: <1295957745.28776.723.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
> +void unregister_uprobe(struct inode *inode, unsigned long offset,
> +                               struct uprobe_consumer *consumer)
> +{
> +       struct prio_tree_iter iter;
> +       struct list_head tmp_list;
> +       struct address_space *mapping;
> +       struct mm_struct *mm, *tmpmm;
> +       struct vm_area_struct *vma;
> +       struct uprobe *uprobe;
> +
> +       if (!inode || !consumer)
> +               return;
> +
> +       uprobe = find_uprobe(inode, offset);
> +       if (!uprobe) {
> +               printk(KERN_ERR "No uprobe found with inode:offset %p %lu\n",
> +                               inode, offset);
> +               return;
> +       }
> +
> +       if (!del_consumer(uprobe, consumer)) {
> +               printk(KERN_ERR "No uprobe found with consumer %p\n",
> +                               consumer);
> +               return;
> +       }
> +
> +       INIT_LIST_HEAD(&tmp_list);
> +
> +       mapping = inode->i_mapping;
> +
> +       mutex_lock(&uprobes_mutex);
> +       if (uprobe->consumers)
> +               goto put_unlock;
> +
> +       spin_lock(&mapping->i_mmap_lock);
> +       vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, 0, 0) {
> +               if (!atomic_inc_not_zero(&vma->vm_mm->mm_users))
> +                       continue;
> +
> +               mm = vma->vm_mm;
> +
> +               if (!atomic_read(&mm->uprobes_count)) {
> +                       mmput(mm);
> +                       continue;
> +               }
> +
> +               if (valid_vma(vma)) {
> +                       list_add(&mm->uprobes_list, &tmp_list);
> +                       mm->uprobes_vaddr = vma->vm_start + offset;
> +               } else
> +                       mmput(mm);
> +       }
> +       spin_unlock(&mapping->i_mmap_lock);
> +       list_for_each_entry_safe(mm, tmpmm, &tmp_list, uprobes_list) {
> +               remove_uprobe(mm, uprobe);
> +               list_del(&mm->uprobes_list);
> +               mmput(mm);
> +       }
> +
> +       if (atomic_read(&uprobe->ref) == 1) {
> +               synchronize_sched();
> +               rb_erase(&uprobe->rb_node, &uprobes_tree);

How is that safe without holding the treelock?

> +               iput(uprobe->inode);
> +       }
> +
> +put_unlock:
> +       mutex_unlock(&uprobes_mutex);
> +       put_uprobe(uprobe);
> +}