[PATCH 2/2] USB: tools: Add a Makefile

[PATCH 2/2] USB: tools: Add a Makefile

[Davidlohr Bueso]

I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

From: Davidlohr Bueso <dave@gnu.org>

Build USB tools easier.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
 tools/usb/Makefile |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100644 tools/usb/Makefile

diff --git a/tools/usb/Makefile b/tools/usb/Makefile
new file mode 100644
index 0000000..3995509
--- /dev/null
+++ b/tools/usb/Makefile
@@ -0,0 +1,13 @@
+# Makefile for building 'usbtest'
+
+CC = $(CROSS_COMPILE)gcc
+PTHREAD_LIBS = -lpthread
+WARNINGS = -Wall -Wextra
+CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS)
+
+all: testusb ffs-test
+%: %.c
+	$(CC) $(CFLAGS) -o $@ $^
+
+clean:
+	$(RM) testusb ffs-test
-- 
1.7.1

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Sergei Shtylyov]

Hello.

On 27-01-2011 22:39, Davidlohr Bueso wrote:

> I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

    This remark should follow the --- tear line, to be automatically stripped 
when applying the patch.

> From: Davidlohr Bueso<dave@gnu.org>

> Build USB tools easier.

> Signed-off-by: Davidlohr Bueso<dave@gnu.org>

WBR, Sergei

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Davidlohr Bueso]

On Fri, 2011-01-28 at 15:19 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 27-01-2011 22:39, Davidlohr Bueso wrote:
> 
> > I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.
> 
>     This remark should follow the --- tear line, to be automatically stripped 
> when applying the patch.
> 

It wasn't meant for the log, that's why it's above the tear line.

Thanks.

> > From: Davidlohr Bueso<dave@gnu.org>
> 
> > Build USB tools easier.
> 
> > Signed-off-by: Davidlohr Bueso<dave@gnu.org>
> 
> WBR, Sergei
> 

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Sergei Shtylyov]

Hello.

On 28-01-2011 15:23, Davidlohr Bueso wrote:

>> On 27-01-2011 22:39, Davidlohr Bueso wrote:

>>> I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.

>>      This remark should follow the --- tear line, to be automatically stripped
>> when applying the patch.

> It wasn't meant for the log, that's why it's above the tear line.

    Everything above the tearline gets into the changelog. If it wasn't meant 
to, it should be below the tearline, or have to be manually edited out of it.

> Thanks.

WBR, Sergei

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Sergei Shtylyov]

On 28-01-2011 15:38, I wrote:

>>>> I originally sent this in several months ago, but never got around to
>>>> correcting the changes, so... here it is.

>>> This remark should follow the --- tear line, to be automatically stripped
>>> when applying the patch.

>> It wasn't meant for the log, that's why it's above the tear line.

> Everything above the tearline gets into the changelog. If it wasn't meant to,
> it should be below the tearline, or have to be manually edited out of it.

    s/it/the patch/

>> Thanks.

    It helps to actually read Documentation/SubmittingPatches sometimes. ;-)

WBR, Sergei

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Davidlohr Bueso]

On Fri, 2011-01-28 at 15:38 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 28-01-2011 15:23, Davidlohr Bueso wrote:
> 
> >> On 27-01-2011 22:39, Davidlohr Bueso wrote:
> 
> >>> I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.
> 
> >>      This remark should follow the --- tear line, to be automatically stripped
> >> when applying the patch.
> 
> > It wasn't meant for the log, that's why it's above the tear line.
> 
>     Everything above the tearline gets into the changelog. If it wasn't meant 
> to, it should be below the tearline, or have to be manually edited out of it.
> 
I should have been clearer. What I meant was that the text I didn't want
in the changelog was above the "From:" (and of course above the ---). I
didn't know it is supposed to be below the tearline. Thanks for pointing
this out. 
If anyone is going to take the patch, do you prefer for me to resend it?


Thanks.

Re: [PATCH 2/2] USB: tools: Add a Makefile

[Greg KH]

On Fri, Jan 28, 2011 at 09:51:37AM -0300, Davidlohr Bueso wrote:
> On Fri, 2011-01-28 at 15:38 +0300, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 28-01-2011 15:23, Davidlohr Bueso wrote:
> > 
> > >> On 27-01-2011 22:39, Davidlohr Bueso wrote:
> > 
> > >>> I originally sent this in several months ago, but never got around to correcting the changes, so... here it is.
> > 
> > >>      This remark should follow the --- tear line, to be automatically stripped
> > >> when applying the patch.
> > 
> > > It wasn't meant for the log, that's why it's above the tear line.
> > 
> >     Everything above the tearline gets into the changelog. If it wasn't meant 
> > to, it should be below the tearline, or have to be manually edited out of it.
> > 
> I should have been clearer. What I meant was that the text I didn't want
> in the changelog was above the "From:" (and of course above the ---). I
> didn't know it is supposed to be below the tearline. Thanks for pointing
> this out. 
> If anyone is going to take the patch, do you prefer for me to resend it?

Yes, please redo it, and the first patch in this series, and resend it
so that I can apply them.

thanks,

greg k-h