From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588Ab1A2IsI (ORCPT ); Sat, 29 Jan 2011 03:48:08 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:52406 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190Ab1A2IsH (ORCPT ); Sat, 29 Jan 2011 03:48:07 -0500 Subject: Re: [PATCH 2/7] [v2] zram: Prevent overflow in logical block size From: Pekka Enberg To: Robert Jennings Cc: Nitin Gupta , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org In-Reply-To: <20110128145816.GC2062@linux.vnet.ibm.com> References: <20110128145602.GA2062@linux.vnet.ibm.com> <20110128145816.GC2062@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Sat, 29 Jan 2011 10:48:05 +0200 Message-ID: <1296290885.30654.6.camel@jaguar> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-01-28 at 08:58 -0600, Robert Jennings wrote: > On a 64K page kernel, the value PAGE_SIZE passed to > blk_queue_logical_block_size would overflow the logical block size > argument (resulting in setting it to 0). > > This patch sets the logical block size to 4096, using a new > ZRAM_LOGICAL_BLOCK_SIZE constant. > > Signed-off-by: Robert Jennings Reviewed-by: Pekka Enberg