From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752137Ab1AaJzW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 31 Jan 2011 04:55:22 -0500
Received: from casper.infradead.org ([85.118.1.10]:34993 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751350Ab1AaJzV convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 31 Jan 2011 04:55:21 -0500
Subject: Re: [PATCH 1/4] kmap_atomic: remove the second parameter
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Herbert Xu <herbert@gondor.hengli.com.au>,
        Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <1296380820-8801-1-git-send-email-amwang@redhat.com>
References: <1296380820-8801-1-git-send-email-amwang@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Mon, 31 Jan 2011 10:56:06 +0100
Message-ID: <1296467766.15234.342.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2011-01-30 at 17:46 +0800, Amerigo Wang wrote:
> 
> Now the second parameter of kmap_atomic() are totally unused,
> this patch removes it from all callers.
> 
> Most of this patch is generated by the following commands:
> 
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkmap_atomic(\(.*\),.*)#kmap_atomic(\1)#' '{}' \;
> find . -name '*.[c|h]' -exec sed -i -e 's#\bkunmap_atomic(\(.*\),.*)#kunmap_atomic(\1)#' '{}' \;
> 
> However, there are some exceptions:
> 
> 1) When the second parameter of kmap_atomic() is a variable
> 2) When the second parameter of kmap_atomic() is not in the same line
> 
> For 1), they are mostly in btrfs and crypto code, have to fix
> one by one;
> For 2), I fixed them by hands too.
> 
> This patch passes 'make allyesconfig' test on both i386 and x86_64.


Right, I had a mostly scripted patch like this as well, IIRC akpm didn't
particularly like the huge patch (in part because it was a flag day
thing).

Maybe cut the patch into slightly smaller bits, like arch/asm,
drivers/gpu, fs/btrfs etc..