From: Jinyoung CHOI <j-young.choi@samsung.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Lu Hongfei <luhongfei@vivo.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Keoseong Park <keosung.park@samsung.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "opensource.kernel@vivo.com" <opensource.kernel@vivo.com>,
Tang Huan <tanghuan@vivo.com>
Subject: RE:(2) [PATCH] scsi: ufs: Optimize the WB flush process to save device power consumption
Date: Thu, 29 Jun 2023 12:11:52 +0900 [thread overview]
Message-ID: <1296674576.21688009582803.JavaMail.epsvc@epcpadp4> (raw)
In-Reply-To: <DM6PR04MB65757599481E7CAA98D89CE1FC24A@DM6PR04MB6575.namprd04.prod.outlook.com>
>>
>> In the original logic, WB Hibern Flush was always on.
>> During suspend flow, the host will determine whether the device needs
>> BKOP or WB flush, and if so, it will keep VCC supply.
>> WB flush is only a part of BKOP, and device that needs BKOP do not
>> necessarily need WB flush if the conditions are not met. Therefore,
>> if WB flush is not needed, it will be better to disable WB Hibern
>> Flush,.....
>I beg to differ on this conclusion.
>If you expect SLC write performance, without fluctuations,
>the host should let the device manage its wb buffer on its own.
>This is exactly what flush on hibernate does and better leave it be.
>
>Thanks,
>Avri
Hi, Lu Hongfei.
I agree with avri.
In fact, I am not sure if there will be a significant improvement in
power consumption.
In addition, for the toggle of the function, a code that compares with
the existing value must be added to prevent unnecessary queries.
Best Regards,
Jinyoung.
prev parent reply other threads:[~2023-06-29 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 7:02 [PATCH] scsi: ufs: Optimize the WB flush process to save device power consumption Lu Hongfei
2023-06-28 11:00 ` Avri Altman
2023-06-29 3:11 ` Jinyoung CHOI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296674576.21688009582803.JavaMail.epsvc@epcpadp4 \
--to=j-young.choi@samsung.com \
--cc=Arthur.Simchaev@wdc.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=martin.petersen@oracle.com \
--cc=opensource.kernel@vivo.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=tanghuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox