public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RTC: Fix for issues in the kernel RTC API.
Date: Wed, 02 Feb 2011 14:28:02 -0800	[thread overview]
Message-ID: <1296685682.3336.302.camel@work-vm> (raw)
In-Reply-To: <1296685479.3336.298.camel@work-vm>

On Wed, 2011-02-02 at 14:24 -0800, John Stultz wrote:
> On Wed, 2011-02-02 at 15:58 -0200, Marcelo Roberto Jimenez wrote: 
> > Again, what the rtc-test kernel RTC and the strongarm RTC user space
> > behavior have changed. Alarm interrupts and update interrupts were
> > generated by a different interrupts in the strongarm driver, and the
> > rtc-test driver also behaved similarly, i.e., an update interrupt did
> > not trigger an alarm interrupt. Currently, rtc_handle_legacy_irq()
> > centralizes the irq processing, and by not checking the generated
> > interrupt, it allows the new behavior, which seemed broken to me.
> 
> So 

Sorry. I didn't finish my thought here. (I *did not* mean "So?" :)

So... yes, we should make sure its not broken. Could you explain some
more details about the different interrupts fro the driver?  If the two
interrupt types come from different sources, is there a problem actually
using the alarm irq to emulate the update irq? In other words, can we
just skip the update irq management code? Or is there a draw back to
that?

thanks
-john






  reply	other threads:[~2011-02-02 22:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 16:30 [PATCH] RTC: Fix for issues in the kernel RTC API Marcelo Roberto Jimenez
2011-02-02  3:00 ` John Stultz
2011-02-02 17:58   ` Marcelo Roberto Jimenez
2011-02-02 22:24     ` John Stultz
2011-02-02 22:28       ` john stultz [this message]
2011-02-03 18:41         ` Marcelo Roberto Jimenez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296685682.3336.302.camel@work-vm \
    --to=johnstul@us.ibm.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroberto@cpti.cetuc.puc-rio.br \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox