From: Peter Zijlstra <peterz@infradead.org>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Nick Bowler <nbowler@elliptictech.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Regression: WARNINGS and lockdep spews in 2.6.38-rc3+ (bisected).
Date: Thu, 03 Feb 2011 10:30:40 +0100 [thread overview]
Message-ID: <1296725440.26581.354.camel@laptop> (raw)
In-Reply-To: <20110203091227.GA1603@zhy>
On Thu, 2011-02-03 at 17:12 +0800, Yong Zhang wrote:
> #ifdef CONFIG_LOCKDEP
> + unsigned long flags;
> +
> local_bh_disable();
> lock_map_acquire(&timer->lockdep_map);
> lock_map_release(&timer->lockdep_map);
> - local_bh_enable();
> + /* raw_local_irq_[save|restore] is to protect _local_bh_enable() */
> + raw_local_irq_save(flags);
> + _local_bh_enable();
> + raw_local_irq_restore(flags);
> #endif
_why_ are you doing the raw_local_irq stuff? That's just weird, and that
comment isn't helping.
Also, calling _local_bh_enable() will leave pending softirqs, not
particularly nice
next prev parent reply other threads:[~2011-02-03 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 3:19 Regression: WARNINGS and lockdep spews in 2.6.38-rc3+ (bisected) Nick Bowler
2011-02-03 9:12 ` Yong Zhang
2011-02-03 9:30 ` Peter Zijlstra [this message]
2011-02-03 10:17 ` Yong Zhang
2011-02-03 10:33 ` Peter Zijlstra
2011-02-03 11:42 ` Yong Zhang
2011-02-08 16:55 ` Peter Zijlstra
2011-02-08 17:39 ` [PATCH] lockdep/timers: Explain in detail the locking problems del_timer_sync() may cause Steven Rostedt
2011-02-16 13:51 ` [tip:core/locking] " tip-bot for Steven Rostedt
2011-02-03 11:50 ` [PATCH 1/2] softirq: introduce loacal_bh_enable_force_wake() Yong Zhang
2011-02-03 11:53 ` [PATCH 2/2] timer: use local_bh_enable_force_wake() in del_timer_sync() Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296725440.26581.354.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox