Re: [PATCH 0/4] RTC regression fixups

John Stultz
2011-02-03T19:16:32Z

On Thu, 2011-02-03 at 15:30 -0200, Marcelo Roberto Jimenez wrote:
> Hi John,
>
> On Thu, Feb 3, 2011 at 00:14, John Stultz <john.stultz@linaro.org> wrote:
> > ...
> > Marcelo: Mind giving this full patch set a go? It seems to resolve
> > the issues in my testing with the rtc-test driver.
>
> I have tested the full set in ARM sa1100. Both the sa1100 RTC driver
> and the rtc-test driver are working fine.

Great to hear! Thanks for testing!

> The only difference in user space behaviour is, as I have mentioned on
> a previous message, that the rtc-test driver receives PIE events no
> matter what, while the previous behaviour was to receive them by
> echoing through the sys interface. But we must think whether this is
> something worth keeping or not.

Yes. With the generic code emulating PIE mode interrupts with an
hrtimer, instead of having it be driver triggered, its not something the
driver can control. So dropping the PIE control in the rtc-test driver
seems like the right approach.

Alessandro: Does this sound ok to you?

> You have actually saved me some work fixing the alarm/update broken
> behaviour on sa1100. Thank you very much. Most of the code in this rtc
> driver is going to /dev/null, I'll send a patch later.

Great. I'll add it to the follow on cleanup patches to remove dead code
that I'll be working on getting in my queue today.

thanks
-john