Re: [PATCH 10/11] mm: Move contig_page_data define to bootmem.c/nobootmem.c

Andrew Morton
2011-02-22T23:48:49Z

On Mon, 7 Feb 2011 15:17:11 -0800
Yinghai Lu <yinghai@kernel.org> wrote:

> We can remove #ifdef in mm/page_alloc.c
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> ---
> mm/bootmem.c | 7 +++++++
> mm/nobootmem.c | 5 +++++
> mm/page_alloc.c | 9 ---------
> 3 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index 4403e2f..79d9c3c 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -23,6 +23,13 @@
>
> #include "internal.h"
>
> +#ifndef CONFIG_NEED_MULTIPLE_NODES
> +struct pglist_data __refdata contig_page_data = {
> + .bdata = &bootmem_node_data[0]
> + };
> +EXPORT_SYMBOL(contig_page_data);
> +#endif

Please fix the layout when moving this code - it's quite busted and as
we're touching the code anyway, we might as well fix it up.

Patches 9, 10 and 11 look good to me and won't conflict with ther
pending work - please merge them up via the appropriate ingotree.