From: James Bottomley <James.Bottomley@suse.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: make scsi_devinfo infrastructure optional
Date: Wed, 09 Feb 2011 12:00:08 -0600 [thread overview]
Message-ID: <1297274408.3016.29.camel@mulgrave.site> (raw)
In-Reply-To: <201102091515.16202.bzolnier@gmail.com>
On Wed, 2011-02-09 at 15:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> Add SCSI_QUIRKS config option (default y and dependent on EMBEDDED
> config option) to allow disabling of scsi_devinfo infrastructure.
>
> The output code size savings are ~14k for CONFIG_SCSI_QUIRKS=n
> (as measured on x86-32):
I don't understand the point of this patch ... without the quirks SCSI
will do the wrong thing on a whole bunch of stuff. The savings look to
be tiny ... since the SCSI module is habitually a lot larger than your
figures suggest.
James
next prev parent reply other threads:[~2011-02-09 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 14:15 [PATCH] scsi: make scsi_devinfo infrastructure optional Bartlomiej Zolnierkiewicz
2011-02-09 18:00 ` James Bottomley [this message]
2011-02-10 9:18 ` Bartlomiej Zolnierkiewicz
2011-02-10 15:07 ` James Bottomley
2011-02-11 9:52 ` Bartlomiej Zolnierkiewicz
2011-02-11 16:06 ` James Bottomley
2011-02-12 12:16 ` Bartlomiej Zolnierkiewicz
2011-02-12 20:54 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297274408.3016.29.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox