Re: [PATCH 5/5] have smaps show transparent huge pages

Dave Hansen
2011-02-10T15:02:12Z

On Thu, 2011-02-10 at 11:20 +0000, Mel Gorman wrote:
> > @@ -394,6 +395,7 @@ static int smaps_pte_range(pmd_t *pmd, u
> > spin_lock(&walk->mm->page_table_lock);
> > } else {
> > smaps_pte_entry(*(pte_t *)pmd, addr, HPAGE_SIZE, walk);
> > + mss->anonymous_thp += HPAGE_SIZE;
>
> I should have thought of this for the previous patch but should this be
> HPAGE_PMD_SIZE instead of HPAGE_SIZE? Right now, they are the same value
> but they are not the same thing.

Probably. There's also a nice BUG() in HPAGE_PMD_SIZE if the THP config
option is off, which is an added bonus.

-- Dave