Re: [PATCH 1/5] pagewalk: only split huge pages when necessary

Mel Gorman
2011-02-10T13:34:27Z

On Thu, Feb 10, 2011 at 02:19:28PM +0100, Andrea Arcangeli wrote:
> On Thu, Feb 10, 2011 at 11:11:25AM +0000, Mel Gorman wrote:
> > Before we goto this retry, there is at a cond_resched(). Just to confirm,
> > we are depending on mmap_sem to prevent khugepaged promoting this back to
> > a hugepage, right? I don't see a problem with that but I want to be
> > sure.
>
> Correct, and we depend on that everywhere as wait_split_huge_page has
> to run without holding spinlocks.
>

In that case;

Acked-by: Mel Gorman <mel@csn.ul.ie>

Thanks.

--
Mel Gorman
SUSE Labs