From: James Bottomley <James.Bottomley@suse.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
mark gross <markgross@thegnar.org>,
David Alan Gilbert <linux@treblig.org>,
linux-kernel@vger.kernel.org, Len <len.brown@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] idle governor: Avoid lock acquisition to read pm_qos before entering idle
Date: Thu, 10 Feb 2011 14:37:43 -0600 [thread overview]
Message-ID: <1297370263.4933.74.camel@mulgrave.site> (raw)
In-Reply-To: <1297366384.2645.175.camel@schen9-DESK>
On Thu, 2011-02-10 at 11:33 -0800, Tim Chen wrote:
> On Thu, 2011-02-10 at 11:45 -0600, James Bottomley wrote:
>
> >
> > What you say is true as long as the value is 32 bits ... perhaps a note
> > of that should be made somewhere?
> >
>
> It seems like pm_qos_add_request, pm_qos_update_request only uses 32
> bits value. Did I miss some cases where the target value for
> pm_qos_object be non-32 bit under some situation?
No ... I'm thinking of the future. On the face of it, if we needed
larger quantities (like s64), the obvious approach would be to change
s32 to s64 which would fail ... horribly. I was just suggesting a nice
reminder comment for this.
James
next prev parent reply other threads:[~2011-02-10 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 1:21 [Patch] idle governor: Avoid lock acquisition to read pm_qos before entering idle Tim Chen
2011-02-10 3:46 ` Andi Kleen
2011-02-10 18:59 ` Rafael J. Wysocki
2011-02-10 5:10 ` mark gross
2011-02-10 16:20 ` Andi Kleen
2011-02-10 17:27 ` Tim Chen
2011-02-10 17:45 ` James Bottomley
2011-02-10 18:50 ` Rafael J. Wysocki
2011-02-10 19:33 ` Tim Chen
2011-02-10 20:37 ` James Bottomley [this message]
2011-02-10 17:55 ` mark gross
2011-02-10 23:17 ` Rafael J. Wysocki
2011-02-11 0:50 ` Tim Chen
2011-02-11 19:22 ` Rafael J. Wysocki
2011-02-11 19:27 ` Tim Chen
2011-02-11 19:33 ` James Bottomley
2011-02-11 20:03 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297370263.4933.74.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=markgross@thegnar.org \
--cc=rjw@sisk.pl \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox