From: Artem Bityutskiy <dedekind1@gmail.com>
To: Antony Pavlov <antony@niisi.msk.ru>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: jedec_probe: initialise make sector erase command variable
Date: Fri, 11 Feb 2011 17:06:27 +0200 [thread overview]
Message-ID: <1297436787.2760.47.camel@localhost> (raw)
In-Reply-To: <1297418437-23553-1-git-send-email-antony@niisi.msk.ru>
On Fri, 2011-02-11 at 13:00 +0300, Antony Pavlov wrote:
> In the commit 08968041bef437ec363623cd3218c2b083537ada
> (mtd: cfi_cmdset_0002: make sector erase command variable)
> introdused a field sector_erase_cmd. In the same commit initialisation
> of cfi->sector_erase_cmd made in cfi_chip_setup()
> (file drivers/mtd/chips/cfi_probe.c), so the CFI chip has no problem:
>
> ...
> cfi->cfi_mode = CFI_MODE_CFI;
> cfi->sector_erase_cmd = CMD(0x30);
> ...
>
> But for the JEDEC chips this initialisation is not carried out,
> so the JEDEC chips have sector_erase_cmd == 0.
>
> It's not possible symply add the line
> p_cfi->sector_erase_cmd = CMD(0x30);
> to the cfi_jedec_setup() function be cause CMD() macros needs
> map and cfi variables. So this patch makes necessary changes.
>
> Signed-off-by: Antony Pavlov <antony@niisi.msk.ru>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-02-11 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 10:00 [PATCH] mtd: jedec_probe: initialise make sector erase command variable Antony Pavlov
2011-02-11 10:02 ` Guillaume LECERF
2011-02-11 15:06 ` Artem Bityutskiy [this message]
2011-02-14 10:16 ` Guillaume LECERF
2011-02-14 11:05 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297436787.2760.47.camel@localhost \
--to=dedekind1@gmail.com \
--cc=antony@niisi.msk.ru \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox