Re: [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver

Daniel Walker
2011-02-15T19:50:13Z

On Tue, 2011-02-15 at 11:35 -0800, David Brown wrote:
> On Fri, Feb 11 2011, Daniel Walker wrote:
>
> > On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote:
> >> +config MSM_IOMMU
> >> + bool "MSM IOMMU Support"
> >> + depends on ARCH_MSM8X60
> >> + select IOMMU_API
> >> + default n
> >> + help
> >> + Support for the IOMMUs found on certain Qualcomm SOCs.
> >> + These IOMMUs allow virtualization of the address space used by most
> >> + cores within the multimedia subsystem.
> >> +
> >> + If unsure, say N here.
> >
> > I think you should just make this a hidden option, unless there is a
> > good reason why any given users might want to turn this off.
>
> In this particular case, the driver is optional, even devices that use
> it will be able to work both with and without it. It makes sense to be
> able to decide whether to have it or not.

Typically we include everything the SoC has regardless of if drivers use
the hardware or not . For instance there could be modules that use the
hardware ..

Regardless of this point, I've nacked the whole series. It looks like
there was very little thought put into this.

Daniel

--

Sent by a consultant of the Qualcomm Innovation Center, Inc.