Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

Steve Muckle
2011-02-11T20:51:57Z

On 02/11/11 12:42, Daniel Walker wrote:
>> static struct resource msm_iommu_jpegd_resources[] = {
>> {
>> - .start = MSM_IOMMU_JPEGD_PHYS,
>> - .end = MSM_IOMMU_JPEGD_PHYS + MSM_IOMMU_JPEGD_SIZE - 1,
>> + .start = 0x07300000,
>> + .end = 0x07300000 + SZ_1M - 1,
>
> Looks worse .. Just put the macros into a static header file for both.

Why bother defining macros for these if they only appear here? I don't
think that adds any value or readability - these addresses are clearly
the physical area for the msm_iommu_jpegd. It just makes it more
annoying to have to look up the values in a separate file if you are
wondering what they are.

thanks,
Steve