Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

David Brown
2011-02-11T22:37:20Z

On Fri, Feb 11 2011, Daniel Walker wrote:

> On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote:
>> Make the IOMMU platform data target-independent in
>> preparation for adding MSM8960 IOMMU support. The IOMMU
>> configuration on MSM8x60 and MSM8960 is identical and the
>> same platform data can be used for both.
>>
>> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
>> ---
>> arch/arm/mach-msm/Makefile | 4 +-
>> .../{devices-msm8x60-iommu.c => devices-iommu.c} | 54 +++++++++----------
>> arch/arm/mach-msm/include/mach/msm_iomap-8x60.h | 36 -------------
>> 3 files changed, 28 insertions(+), 66 deletions(-)
>> rename arch/arm/mach-msm/{devices-msm8x60-iommu.c => devices-iommu.c} (93%)
>
> If it's like what you and David are suggesting I think you would need a
> SoC designation in the filename ..

It is functionality that will be shared across multiple socs. Putting
the name of a specific soc would just be misleading. Currently, it's
our only iommu. Support for another family that uses a different iommu
could perhaps call it iommu2.

David