From: Daniel Walker <dwalker@codeaurora.org>
To: David Brown <davidb@codeaurora.org>
Cc: Stepan Moskovchenko <stepanm@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets
Date: Fri, 11 Feb 2011 14:47:36 -0800 [thread overview]
Message-ID: <1297464456.4852.34.camel@m0nster> (raw)
In-Reply-To: <8ya7hd6kxk1.fsf@huya.qualcomm.com>
On Fri, 2011-02-11 at 14:37 -0800, David Brown wrote:
> On Fri, Feb 11 2011, Daniel Walker wrote:
>
> > On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote:
> >> Make the IOMMU platform data target-independent in
> >> preparation for adding MSM8960 IOMMU support. The IOMMU
> >> configuration on MSM8x60 and MSM8960 is identical and the
> >> same platform data can be used for both.
> >>
> >> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
> >> ---
> >> arch/arm/mach-msm/Makefile | 4 +-
> >> .../{devices-msm8x60-iommu.c => devices-iommu.c} | 54 +++++++++----------
> >> arch/arm/mach-msm/include/mach/msm_iomap-8x60.h | 36 -------------
> >> 3 files changed, 28 insertions(+), 66 deletions(-)
> >> rename arch/arm/mach-msm/{devices-msm8x60-iommu.c => devices-iommu.c} (93%)
> >
> > If it's like what you and David are suggesting I think you would need a
> > SoC designation in the filename ..
>
> It is functionality that will be shared across multiple socs. Putting
> the name of a specific soc would just be misleading. Currently, it's
> our only iommu. Support for another family that uses a different iommu
> could perhaps call it iommu2.
Your missing my point. I'm saying it doesn't look flexible enough to
allow support for multiple SoCs .. Is everything going to be identical
across all the supported socs ?
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
next prev parent reply other threads:[~2011-02-11 22:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 20:28 [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver Stepan Moskovchenko
2011-02-11 20:28 ` [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets Stepan Moskovchenko
2011-02-11 20:42 ` Daniel Walker
2011-02-11 20:51 ` Steve Muckle
2011-02-11 20:58 ` Daniel Walker
2011-02-11 21:00 ` Steve Muckle
2011-02-11 21:03 ` Daniel Walker
2011-02-11 21:03 ` David Brown
2011-02-11 21:14 ` Daniel Walker
2011-02-11 21:53 ` David Brown
2011-02-11 22:00 ` Daniel Walker
2011-02-11 22:12 ` Daniel Walker
2011-02-11 22:37 ` David Brown
2011-02-11 22:47 ` Daniel Walker [this message]
2011-02-11 23:16 ` David Brown
2011-02-11 23:35 ` Daniel Walker
2011-02-11 20:28 ` [PATCH 3/3] msm: iommu: Enable IOMMU support for MSM8960 Stepan Moskovchenko
2011-02-11 20:38 ` [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver Daniel Walker
2011-02-15 19:35 ` David Brown
2011-02-15 19:49 ` Daniel Walker
2011-02-25 0:12 ` David Brown
2011-02-16 0:36 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297464456.4852.34.camel@m0nster \
--to=dwalker@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox