public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: namhyung@gmail.com, akpm@linux-foundation.org,
	a.p.zijlstra@chello.nl, dhaval.giani@gmail.com, efault@gmx.de,
	gregkh@suse.de, linux-kernel@vger.kernel.org, mingo@elte.hu,
	torvalds@linux-foundation.org
Cc: <stable@kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "kernel/user.c: add lock release annotation on free_user()" has been added to the 2.6.32-longterm tree
Date: Tue, 15 Feb 2011 14:51:10 -0800	[thread overview]
Message-ID: <12978102701595@kroah.org> (raw)
In-Reply-To: <1297404421.7865.24.camel@marge.simson.net>


This is a note to let you know that I've just added the patch titled

    kernel/user.c: add lock release annotation on free_user()

to the 2.6.32-longterm tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.32.git;a=summary

The filename of the patch is:
     kernel-user.c-add-lock-release-annotation-on-free_user.patch
and it can be found in the queue-2.6.32 subdirectory.

If you, or anyone else, feels it should not be added to the 2.6.32 longterm tree,
please let <stable@kernel.org> know about it.


>From efault@gmx.de  Tue Feb 15 14:39:42 2011
From: Namhyung Kim <namhyung@gmail.com>
From: Mike Galbraith <efault@gmx.de>
Date: Fri, 11 Feb 2011 07:07:01 +0100
Subject: kernel/user.c: add lock release annotation on free_user()
To: Dhaval Giani <dhaval.giani@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@elte.hu>, Greg Kroah-Hartman <gregkh@suse.de>
Message-ID: <1297404421.7865.24.camel@marge.simson.net>


From: Namhyung Kim <namhyung@gmail.com>

commit 571428be550fbe37160596995e96ad398873fcbd upstream.

free_user() releases uidhash_lock but was missing annotation.  Add it.
This removes following sparse warnings:

 include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock
 kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Dhaval Giani <dhaval.giani@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


---
 kernel/user.c |    1 +
 1 file changed, 1 insertion(+)

--- a/kernel/user.c
+++ b/kernel/user.c
@@ -91,6 +91,7 @@ static struct user_struct *uid_hash_find
  * upon function exit.
  */
 static void free_user(struct user_struct *up, unsigned long flags)
+	__releases(&uidhash_lock)
 {
 	uid_hash_remove(up);
 	spin_unlock_irqrestore(&uidhash_lock, flags);


Patches currently in longterm-queue-2.6.32 which might be from namhyung@gmail.com are


  reply	other threads:[~2011-02-15 22:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10  8:48 [PATCH 01/28] sched: Remove USER_SCHED stable-bot for Dhaval Giani
2011-02-10 18:30 ` Dhaval Giani
2011-02-10 18:35   ` Dhaval Giani
2011-02-11  6:04     ` [PATCH 29/28] sched: Remove some dead code Mike Galbraith
2011-02-15 22:51       ` Patch "sched: Remove some dead code" has been added to the 2.6.32-longterm tree gregkh
2011-02-11  6:07     ` [PATCH 30/28] kernel/user.c: add lock release annotation on free_user() Mike Galbraith
2011-02-15 22:51       ` gregkh [this message]
2011-02-11  6:08     ` [PATCH 01/28] sched: Remove USER_SCHED Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12978102701595@kroah.org \
    --to=gregkh@suse.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dhaval.giani@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@gmail.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox