public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/2] USB: ffs-test: fix header path
Date: Wed, 16 Feb 2011 10:38:36 -0300	[thread overview]
Message-ID: <1297863516.2184.1.camel@offworld> (raw)
In-Reply-To: <1297012413.2039.8.camel@offworld>

Hi Greg, just following up on this (ping) with the requested changes.

Thanks.

On Sun, 2011-02-06 at 14:13 -0300, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
> 
> When compiling this program the functionfs.h header cannot be found, producing:
> ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory
> 
> This patch also fixes the following warning:
> ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’
> 
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
>  tools/usb/ffs-test.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c
> index bbe2e3a..f2c6524 100644
> --- a/tools/usb/ffs-test.c
> +++ b/tools/usb/ffs-test.c
> @@ -37,7 +37,7 @@
>  #include <sys/types.h>
>  #include <unistd.h>
>  
> -#include <linux/usb/functionfs.h>
> +#include "../../include/linux/usb/functionfs.h"
>  
> 
>  /******************** Little Endian Handling ********************************/
> @@ -450,7 +450,7 @@ invalid:
>  		    len, expected, *p);
>  		for (p = buf, len = 0; len < nbytes; ++p, ++len) {
>  			if (0 == (len % 32))
> -				fprintf(stderr, "%4d:", len);
> +				fprintf(stderr, "%4zd", len);
>  			fprintf(stderr, " %02x", *p);
>  			if (31 == (len % 32))
>  				fprintf(stderr, "\n");



  reply	other threads:[~2011-02-16 13:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 17:13 [PATCH v2 1/2] USB: ffs-test: fix header path Davidlohr Bueso
2011-02-16 13:38 ` Davidlohr Bueso [this message]
2011-02-17 18:42 ` Greg KH
2011-02-17 18:57   ` Davidlohr Bueso
2011-02-17 19:05     ` Greg KH
2011-02-27  7:58       ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297863516.2184.1.camel@offworld \
    --to=dave@gnu.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.nazarewicz@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox