* [PATCH v2 1/2] USB: ffs-test: fix header path @ 2011-02-06 17:13 Davidlohr Bueso 2011-02-16 13:38 ` Davidlohr Bueso 2011-02-17 18:42 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Davidlohr Bueso @ 2011-02-06 17:13 UTC (permalink / raw) To: Michal Nazarewicz, Greg Kroah-Hartman; +Cc: LKML, linux-usb From: Davidlohr Bueso <dave@gnu.org> When compiling this program the functionfs.h header cannot be found, producing: ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory This patch also fixes the following warning: ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ Signed-off-by: Davidlohr Bueso <dave@gnu.org> --- tools/usb/ffs-test.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c index bbe2e3a..f2c6524 100644 --- a/tools/usb/ffs-test.c +++ b/tools/usb/ffs-test.c @@ -37,7 +37,7 @@ #include <sys/types.h> #include <unistd.h> -#include <linux/usb/functionfs.h> +#include "../../include/linux/usb/functionfs.h" /******************** Little Endian Handling ********************************/ @@ -450,7 +450,7 @@ invalid: len, expected, *p); for (p = buf, len = 0; len < nbytes; ++p, ++len) { if (0 == (len % 32)) - fprintf(stderr, "%4d:", len); + fprintf(stderr, "%4zd", len); fprintf(stderr, " %02x", *p); if (31 == (len % 32)) fprintf(stderr, "\n"); -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] USB: ffs-test: fix header path 2011-02-06 17:13 [PATCH v2 1/2] USB: ffs-test: fix header path Davidlohr Bueso @ 2011-02-16 13:38 ` Davidlohr Bueso 2011-02-17 18:42 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Davidlohr Bueso @ 2011-02-16 13:38 UTC (permalink / raw) To: Michal Nazarewicz; +Cc: Greg Kroah-Hartman, LKML, linux-usb Hi Greg, just following up on this (ping) with the requested changes. Thanks. On Sun, 2011-02-06 at 14:13 -0300, Davidlohr Bueso wrote: > From: Davidlohr Bueso <dave@gnu.org> > > When compiling this program the functionfs.h header cannot be found, producing: > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory > > This patch also fixes the following warning: > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > --- > tools/usb/ffs-test.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c > index bbe2e3a..f2c6524 100644 > --- a/tools/usb/ffs-test.c > +++ b/tools/usb/ffs-test.c > @@ -37,7 +37,7 @@ > #include <sys/types.h> > #include <unistd.h> > > -#include <linux/usb/functionfs.h> > +#include "../../include/linux/usb/functionfs.h" > > > /******************** Little Endian Handling ********************************/ > @@ -450,7 +450,7 @@ invalid: > len, expected, *p); > for (p = buf, len = 0; len < nbytes; ++p, ++len) { > if (0 == (len % 32)) > - fprintf(stderr, "%4d:", len); > + fprintf(stderr, "%4zd", len); > fprintf(stderr, " %02x", *p); > if (31 == (len % 32)) > fprintf(stderr, "\n"); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] USB: ffs-test: fix header path 2011-02-06 17:13 [PATCH v2 1/2] USB: ffs-test: fix header path Davidlohr Bueso 2011-02-16 13:38 ` Davidlohr Bueso @ 2011-02-17 18:42 ` Greg KH 2011-02-17 18:57 ` Davidlohr Bueso 1 sibling, 1 reply; 6+ messages in thread From: Greg KH @ 2011-02-17 18:42 UTC (permalink / raw) To: Davidlohr Bueso; +Cc: Michal Nazarewicz, Greg Kroah-Hartman, LKML, linux-usb On Sun, Feb 06, 2011 at 02:13:33PM -0300, Davidlohr Bueso wrote: > From: Davidlohr Bueso <dave@gnu.org> > > When compiling this program the functionfs.h header cannot be found, producing: > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory > > This patch also fixes the following warning: > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > --- > tools/usb/ffs-test.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) This patch doesn't apply properly to the linux-next branch, what did you make it against? confused, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] USB: ffs-test: fix header path 2011-02-17 18:42 ` Greg KH @ 2011-02-17 18:57 ` Davidlohr Bueso 2011-02-17 19:05 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Davidlohr Bueso @ 2011-02-17 18:57 UTC (permalink / raw) To: Greg KH; +Cc: Michal Nazarewicz, Greg Kroah-Hartman, LKML, linux-usb On Thu, 2011-02-17 at 10:42 -0800, Greg KH wrote: > On Sun, Feb 06, 2011 at 02:13:33PM -0300, Davidlohr Bueso wrote: > > From: Davidlohr Bueso <dave@gnu.org> > > > > When compiling this program the functionfs.h header cannot be found, producing: > > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory > > > > This patch also fixes the following warning: > > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ > > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > > --- > > tools/usb/ffs-test.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > This patch doesn't apply properly to the linux-next branch, what did you > make it against? > It was against Linus' tree (did a pull right before submitting the patch). > confused, > > greg k-h > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] USB: ffs-test: fix header path 2011-02-17 18:57 ` Davidlohr Bueso @ 2011-02-17 19:05 ` Greg KH 2011-02-27 7:58 ` Davidlohr Bueso 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2011-02-17 19:05 UTC (permalink / raw) To: Davidlohr Bueso; +Cc: Greg KH, Michal Nazarewicz, LKML, linux-usb On Thu, Feb 17, 2011 at 03:57:32PM -0300, Davidlohr Bueso wrote: > On Thu, 2011-02-17 at 10:42 -0800, Greg KH wrote: > > On Sun, Feb 06, 2011 at 02:13:33PM -0300, Davidlohr Bueso wrote: > > > From: Davidlohr Bueso <dave@gnu.org> > > > > > > When compiling this program the functionfs.h header cannot be found, producing: > > > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory > > > > > > This patch also fixes the following warning: > > > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ > > > > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > > > --- > > > tools/usb/ffs-test.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > This patch doesn't apply properly to the linux-next branch, what did you > > make it against? > > > > It was against Linus' tree (did a pull right before submitting the > patch). Ah, so you think this is needed for Linus's tree now? Care to resend it and I'll queue it up to the proper tree, sorry, I missed that. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] USB: ffs-test: fix header path 2011-02-17 19:05 ` Greg KH @ 2011-02-27 7:58 ` Davidlohr Bueso 0 siblings, 0 replies; 6+ messages in thread From: Davidlohr Bueso @ 2011-02-27 7:58 UTC (permalink / raw) To: Greg KH; +Cc: Greg KH, Michal Nazarewicz, LKML, linux-usb On Thu, 2011-02-17 at 11:05 -0800, Greg KH wrote: > On Thu, Feb 17, 2011 at 03:57:32PM -0300, Davidlohr Bueso wrote: > > On Thu, 2011-02-17 at 10:42 -0800, Greg KH wrote: > > > On Sun, Feb 06, 2011 at 02:13:33PM -0300, Davidlohr Bueso wrote: > > > > From: Davidlohr Bueso <dave@gnu.org> > > > > > > > > When compiling this program the functionfs.h header cannot be found, producing: > > > > ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory > > > > > > > > This patch also fixes the following warning: > > > > ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ > > > > > > > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > > > > --- > > > > tools/usb/ffs-test.c | 4 ++-- > > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > This patch doesn't apply properly to the linux-next branch, what did you > > > make it against? > > > > > > > It was against Linus' tree (did a pull right before submitting the > > patch). > > Ah, so you think this is needed for Linus's tree now? Care to resend it > and I'll queue it up to the proper tree, sorry, I missed that. > Sorry about the delay, you wouldn't believe the problems I have with a slow ('90s) internet connection when trying to clone a tree. Here is a version against the latest linux-next. Thanks. From: Davidlohr Bueso <dave@gnu.org> Date: Sun, 27 Feb 2011 04:55:59 -0300 Subject: [PATCH] USB: ffs-test: fix header path When compiling this program the functionfs.h header cannot be found, producing: ffs-test.c:40: fatal error: linux/usb/functionfs.h: No such file or directory This patch also fixes the following warning: ffs-test.c:453: warning: format ‘%4d’ expects type ‘int’, but argument 3 has type ‘size_t’ Signed-off-by: Davidlohr Bueso <dave@gnu.org> --- tools/usb/ffs-test.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c index bbe2e3a..b9c7986 100644 --- a/tools/usb/ffs-test.c +++ b/tools/usb/ffs-test.c @@ -37,7 +37,7 @@ #include <sys/types.h> #include <unistd.h> -#include <linux/usb/functionfs.h> +#include "../../include/linux/usb/functionfs.h" /******************** Little Endian Handling ********************************/ @@ -450,7 +450,7 @@ invalid: len, expected, *p); for (p = buf, len = 0; len < nbytes; ++p, ++len) { if (0 == (len % 32)) - fprintf(stderr, "%4d:", len); + fprintf(stderr, "%4zd:", len); fprintf(stderr, " %02x", *p); if (31 == (len % 32)) fprintf(stderr, "\n"); -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-27 9:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-06 17:13 [PATCH v2 1/2] USB: ffs-test: fix header path Davidlohr Bueso 2011-02-16 13:38 ` Davidlohr Bueso 2011-02-17 18:42 ` Greg KH 2011-02-17 18:57 ` Davidlohr Bueso 2011-02-17 19:05 ` Greg KH 2011-02-27 7:58 ` Davidlohr Bueso
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox