Re: [PATCH 1/3] perf events: fix WARN_ON_ONCE for 64-bit raw data, SW events

Peter Zijlstra
2011-02-18T15:00:21Z

On Fri, 2011-02-18 at 12:53 -0200, Arnaldo Carvalho de Melo wrote:
>
> > So size should be changed to u64 rather than modifying the
> WARN_ON_ONCE?
>
> Yeah, I guess so, 32-bit has to die it seems, gets in the way of
> testing
> :-)

No!

1) don't use RAW unless you have to
2) you don't have to, goto 1
3) if you do anyway, ensure its properly padded