Re: [PATCH 1/3] perf events: fix WARN_ON_ONCE for 64-bit raw data, SW events

Peter Zijlstra
2011-02-18T10:59:15Z

On Thu, 2011-02-17 at 22:53 -0700, David Ahern wrote:
> This check does not work out for 64-bit counter:
>
> sizeof(u32) + sizeof(u64) = 4 + 8 = 12
>
> which does not pass the WARN_ON_ONCE test. I'm guessing (hoping
> really) that the intent is that the size of the raw data is a
> multiple of 4 bytes, not 8.

No the data must come in 8bytes strides.