From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
dtor@vmware.com, linux-kernel@vger.kernel.org,
geert@linux-m68k.org, rusty@rustcorp.com.au,
linux-m68k@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions
Date: Fri, 18 Feb 2011 18:14:15 -0600 [thread overview]
Message-ID: <1298074455.2460.85.camel@pasglop> (raw)
In-Reply-To: <AANLkTikd-OBhe6-wK7-Xvv-asNSeVKs+0-a0d3FF2KVu@mail.gmail.com>
On Thu, 2011-02-17 at 15:08 -0800, Linus Torvalds wrote:
> On Thu, Feb 17, 2011 at 2:48 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Gaah, I didn't realize that we've never had to do anything like this
> > before, and that the exception table is all arch-specific code. So we
> > don't have any way to "output that damned pointer and stop whining
> > about it" model at all.
>
> Actually, I don't think the problem is about ".word" vs ".xword". We
> should be able to just use ".long" everywhere.
>
> But the symbol _name_ may have different prefixes, and when we use
> "asm()" at the top level, we can't use the expressions to fix it up.
> So a
>
> asm(".long %0":'i" (symbol))
>
> doesn't work (ignore the lack of section naming, that's not
> important), and neither can we just do something like
>
> #define output_asm_pointer(section, symbol) \
> asm(".long " #symbol)
>
> portably, because some linker formats want to see prepended underscores etc.
Except that .long is 32-bit on ppc64 :-( You need .llong for 64-bit.
Cheers,
Ben.
next prev parent reply other threads:[~2011-02-19 0:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 0:02 [PATCH 1/3] module: deal with alignment issues in built-in module versions Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 2/3] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 3/3] module: do not hide __modver_version_show declaration behind ifdef Dmitry Torokhov
2011-02-08 21:12 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Geert Uytterhoeven
2011-02-17 12:43 ` Geert Uytterhoeven
2011-02-11 22:03 ` [PATCH v2] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-13 23:04 ` Rusty Russell
2011-02-17 17:24 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Linus Torvalds
2011-02-17 17:31 ` Dmitry Torokhov
2011-02-17 17:45 ` Linus Torvalds
2011-02-17 18:00 ` Dmitry Torokhov
2011-02-17 18:06 ` Linus Torvalds
2011-02-17 21:01 ` David Miller
2011-02-17 21:11 ` Linus Torvalds
2011-02-17 21:17 ` David Miller
2011-02-17 21:54 ` Linus Torvalds
2011-02-17 22:01 ` David Miller
2011-02-17 22:19 ` Dmitry Torokhov
2011-02-17 22:23 ` David Miller
2011-02-17 22:48 ` Linus Torvalds
2011-02-17 23:08 ` Linus Torvalds
2011-02-17 23:19 ` David Miller
2011-02-19 0:14 ` Benjamin Herrenschmidt [this message]
2011-02-21 4:00 ` Rusty Russell
2011-02-21 7:38 ` Geert Uytterhoeven
2011-02-21 7:49 ` Dmitry Torokhov
2011-02-21 13:25 ` Geert Uytterhoeven
2011-02-22 1:58 ` Benjamin Herrenschmidt
2011-02-22 2:03 ` Linus Torvalds
2011-02-22 7:02 ` Dmitry Torokhov
2011-02-22 17:08 ` Jesper Nilsson
2011-02-22 20:47 ` Linus Torvalds
2011-02-23 15:00 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298074455.2460.85.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dtor@vmware.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox