From: Mike Galbraith <efault@gmx.de>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix
Date: Mon, 21 Feb 2011 04:13:25 +0100 [thread overview]
Message-ID: <1298258005.7853.2.camel@marge.simson.net> (raw)
In-Reply-To: <1298222533.7881.15.camel@marge.simson.net>
On Sun, 2011-02-20 at 18:22 +0100, Mike Galbraith wrote:
> On Sun, 2011-02-20 at 22:10 +0800, Yong Zhang wrote:
> > On Sun, Feb 20, 2011 at 02:09:39PM +0100, Mike Galbraith wrote:
> > > On Sun, 2011-02-20 at 15:08 +0800, Yong Zhang wrote:
> > > > Now enable/disable autogroup at runtime is just a flag,
> > > > it doesn't take effect on current process of the system.
> > >
> > > Yup, they only move upon migration, which can take up to forever.
> >
> > Yeah. so on UP, the user can have autogroup forever or not, and
> > sched_autogroup_enable is a nop.
>
> Yup, and that's the best argument for doing the active switch.
>
> > Apart from runtime enable/disable issue, I think patch1~3 could
> > still be applied beause they really fix some problem or bring
> > some improvement.
>
> Yeah.
>
> Your whole series looked fine to me at a glance (sunday;), with the
> exception of #2, that one is maybe iffy, depending on point of view.
Hm, my mind wandered off to different file somewhere along the line :)
-Mike
next prev parent reply other threads:[~2011-02-21 3:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 7:08 [PATCH 0/5] autogroup runtime enable/disable tuning fix Yong Zhang
2011-02-20 7:08 ` [PATCH 1/5] sched, autogroup, sysctl: use proc_dointvec_minmax instead Yong Zhang
2011-02-23 12:05 ` [tip:sched/core] sched, autogroup, sysctl: Use proc_dointvec_minmax() instead tip-bot for Yong Zhang
2011-02-20 7:08 ` [PATCH 2/5] sched: hide cfs_rq of autogroup if autogroup is disabled Yong Zhang
2011-02-20 7:08 ` [PATCH 3/5] sched, autogroup: stop going ahead " Yong Zhang
2011-02-23 12:05 ` [tip:sched/core] sched, autogroup: Stop " tip-bot for Yong Zhang
2011-02-20 7:08 ` [PATCH 4/5] sched: refactor task_group() Yong Zhang
2011-02-20 7:08 ` [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix Yong Zhang
2011-02-20 13:09 ` Mike Galbraith
2011-02-20 14:10 ` Yong Zhang
2011-02-20 17:22 ` Mike Galbraith
2011-02-21 3:13 ` Mike Galbraith [this message]
2011-02-21 9:05 ` Yong Zhang
2011-02-21 16:36 ` Peter Zijlstra
2011-02-21 21:12 ` Ingo Molnar
2011-02-22 3:13 ` Yong Zhang
2011-02-22 9:56 ` Peter Zijlstra
2011-02-22 12:10 ` [PATCH V2] sched, autogroup: always show autogroup name in sched_debug Yong Zhang
2011-02-22 14:02 ` Mike Galbraith
2011-02-22 14:32 ` Yong Zhang
2011-02-23 12:06 ` [tip:sched/core] sched, autogroup: Stop claiming ownership of the root task group tip-bot for Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298258005.7853.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox