From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795Ab1BVBth (ORCPT ); Mon, 21 Feb 2011 20:49:37 -0500 Received: from mail-vx0-f174.google.com ([209.85.220.174]:53762 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343Ab1BVBtf (ORCPT ); Mon, 21 Feb 2011 20:49:35 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=SL4CiHCAp4DrTkSwXELwOxs0Z50CQI3Ukyyau7TpV2TNoQqXQ+IG97Fy4HkvDHn+0M UPakWsi+zMHCyx4okS/CsWhxaBQF16qI2i12IX0Qe8XHTXyNaIBGc5kow6s9US0zPxfz ED1PzLGaZ88NxvoNKJ0PZJHbOVeZTvW9+efR4= Subject: [PATCH] video: da8xx-fb: fix section mismatch warning From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Sudhakar Rajashekhara , Paul Mundt , linux-fbdev@vger.kernel.org Content-Type: text/plain Date: Tue, 22 Feb 2011 09:52:42 +0800 Message-Id: <1298339562.3903.3.camel@mola> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch includes below fixes: 1. Mark fb_probe as __devinit to fix below section mismatch warning. WARNING: drivers/video/built-in.o(.data+0x13c): Section mismatch in reference from the variable da8xx_fb_driver to the function .init.text:fb_probe() The variable da8xx_fb_driver references the function __init fb_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, 2. fb_remove is marked __devexit, thus add __devexit_p around reference to fb_remove. Signed-off-by: Axel Lin --- drivers/video/da8xx-fb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index 8d61ef9..246f1c0 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -899,7 +899,7 @@ static struct fb_ops da8xx_fb_ops = { .fb_blank = cfb_blank, }; -static int __init fb_probe(struct platform_device *device) +static int __devinit fb_probe(struct platform_device *device) { struct da8xx_lcdc_platform_data *fb_pdata = device->dev.platform_data; @@ -1165,7 +1165,7 @@ static int fb_resume(struct platform_device *dev) static struct platform_driver da8xx_fb_driver = { .probe = fb_probe, - .remove = fb_remove, + .remove = __devexit_p(fb_remove), .suspend = fb_suspend, .resume = fb_resume, .driver = { -- 1.7.2