From: Lin Ming <ming.m.lin@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
Stephane Eranian <eranian@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf: x86, add SandyBridge support
Date: Thu, 24 Feb 2011 22:55:38 +0800 [thread overview]
Message-ID: <1298559338.2220.48.camel@localhost> (raw)
In-Reply-To: <20110224142523.GJ5818@one.firstfloor.org>
On Thu, 2011-02-24 at 22:25 +0800, Andi Kleen wrote:
> On Thu, Feb 24, 2011 at 10:11:24PM +0800, Lin Ming wrote:
> > On Thu, 2011-02-24 at 22:02 +0800, Andi Kleen wrote:
> > > > + [ C(OP_READ) ] = {
> > > > + [ C(RESULT_ACCESS) ] = 0x04d1, /* MEM_LOAD_UOPS_RETIRED.LLC_HIT */
> > > > + [ C(RESULT_MISS) ] = 0x0,
> > > > + },
> > > > + [ C(OP_WRITE) ] = {
> > > > + [ C(RESULT_ACCESS) ] = 0x0424, /* L2_RQSTS.RFO_HITS */
> > > > + [ C(RESULT_MISS) ] = 0x0824, /* L2_RQSTS.RFO_MISS */
> > >
> > > No! You really need offcore here. L2 is not LLC!!!
> > > See the offcore patchkit which fixes this for Nehalem.
> >
> > Yes, I know that.
> > But I write it like this for now since the offcore patchkit has not been
> > merged yet.
>
> It's just wrong. Please don't merge more bugs.
OK. I'll fix it and include this patch in the offcore patchkit.
>
> -Andi
>
next prev parent reply other threads:[~2011-02-24 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 13:59 [PATCH -tip] perf: x86, add SandyBridge support Lin Ming
2011-02-24 14:02 ` Andi Kleen
2011-02-24 14:11 ` Lin Ming
2011-02-24 14:25 ` Andi Kleen
2011-02-24 14:55 ` Lin Ming [this message]
2011-02-24 14:03 ` Lin Ming
2011-02-24 16:57 ` Ingo Molnar
2011-02-25 8:55 ` Lin Ming
2011-02-25 8:56 ` Stephane Eranian
2011-02-25 8:59 ` Lin Ming
2011-02-24 16:53 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298559338.2220.48.camel@localhost \
--to=ming.m.lin@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox