From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754983Ab1BXOzn (ORCPT ); Thu, 24 Feb 2011 09:55:43 -0500 Received: from mga14.intel.com ([143.182.124.37]:22357 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754324Ab1BXOzi (ORCPT ); Thu, 24 Feb 2011 09:55:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.62,218,1297065600"; d="scan'208";a="393516721" Subject: Re: [PATCH -tip] perf: x86, add SandyBridge support From: Lin Ming To: Andi Kleen Cc: Peter Zijlstra , Ingo Molnar , Stephane Eranian , linux-kernel In-Reply-To: <20110224142523.GJ5818@one.firstfloor.org> References: <1298555968.2220.15.camel@localhost> <20110224140214.GI5818@one.firstfloor.org> <1298556684.2220.26.camel@localhost> <20110224142523.GJ5818@one.firstfloor.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 24 Feb 2011 22:55:38 +0800 Message-Id: <1298559338.2220.48.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 (2.28.0-2.fc12) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-02-24 at 22:25 +0800, Andi Kleen wrote: > On Thu, Feb 24, 2011 at 10:11:24PM +0800, Lin Ming wrote: > > On Thu, 2011-02-24 at 22:02 +0800, Andi Kleen wrote: > > > > + [ C(OP_READ) ] = { > > > > + [ C(RESULT_ACCESS) ] = 0x04d1, /* MEM_LOAD_UOPS_RETIRED.LLC_HIT */ > > > > + [ C(RESULT_MISS) ] = 0x0, > > > > + }, > > > > + [ C(OP_WRITE) ] = { > > > > + [ C(RESULT_ACCESS) ] = 0x0424, /* L2_RQSTS.RFO_HITS */ > > > > + [ C(RESULT_MISS) ] = 0x0824, /* L2_RQSTS.RFO_MISS */ > > > > > > No! You really need offcore here. L2 is not LLC!!! > > > See the offcore patchkit which fixes this for Nehalem. > > > > Yes, I know that. > > But I write it like this for now since the offcore patchkit has not been > > merged yet. > > It's just wrong. Please don't merge more bugs. OK. I'll fix it and include this patch in the offcore patchkit. > > -Andi >