[PATCH 04/10] PTI Makefile and Kconfig additions.

[PATCH 04/10] PTI Makefile and Kconfig additions.

[james_p_freyensee]

From: J Freyensee <james_p_freyensee@linux.intel.com>

This allows the Intel implementation of the PTI standard to be
compiled and configured in Kconfig.

Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
---
 drivers/misc/Kconfig  |   12 ++++++++++++
 drivers/misc/Makefile |    1 +
 2 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 4d073f1..f8076f1 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -136,6 +136,18 @@ config PHANTOM
 	  If you choose to build module, its name will be phantom. If unsure,
 	  say N here.
 
+config INTEL_MID_PTI
+        tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+        help
+          The PTI (Parallel Trace Interface) driver directs
+          trace data routed from various parts in the system out
+          through an Intel Penwell PTI port and out of the mobile
+          device for analysis with a debugging tool (Lauterbach or Fido).
+
+          You should select this driver if the target kernel is meant for
+          an Intel Atom (non-netbook) mobile device containing a MIPI
+          P1149.7 standard implementation.
+
 config SGI_IOC4
 	tristate "SGI IOC4 Base IO support"
 	depends on PCI
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 98009cc..cae0463 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -6,6 +6,7 @@ obj-$(CONFIG_IBM_ASM)		+= ibmasm/
 obj-$(CONFIG_AD525X_DPOT)	+= ad525x_dpot.o
 obj-$(CONFIG_AD525X_DPOT_I2C)	+= ad525x_dpot-i2c.o
 obj-$(CONFIG_AD525X_DPOT_SPI)	+= ad525x_dpot-spi.o
+obj-$(CONFIG_INTEL_MID_PTI)     += pti.o
 obj-$(CONFIG_ATMEL_PWM)		+= atmel_pwm.o
 obj-$(CONFIG_ATMEL_SSC)		+= atmel-ssc.o
 obj-$(CONFIG_ATMEL_TCLIB)	+= atmel_tclib.o
-- 
1.7.2.3

Re: [PATCH 04/10] PTI Makefile and Kconfig additions.

[Arnd Bergmann]

On Thursday 24 February 2011, james_p_freyensee@linux.intel.com wrote:
> 
> From: J Freyensee <james_p_freyensee@linux.intel.com>
> 
> This allows the Intel implementation of the PTI standard to be
> compiled and configured in Kconfig.
> 
> Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>

This belongs together with the pti.c file, just merge the patches
into one.

The Kconfig description is a nice text, how about copying it to the
changeset so that reviewers know what the driver is about?

	Arnd

Re: [PATCH 04/10] PTI Makefile and Kconfig additions.

[J Freyensee]

On Mon, 2011-02-28 at 10:31 +0100, Arnd Bergmann wrote:
> On Thursday 24 February 2011, james_p_freyensee@linux.intel.com wrote:
> > 
> > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > 
> > This allows the Intel implementation of the PTI standard to be
> > compiled and configured in Kconfig.
> > 
> > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> 
> This belongs together with the pti.c file, just merge the patches
> into one.
> 
> The Kconfig description is a nice text, how about copying it to the
> changeset so that reviewers know what the driver is about?
> 
> 	Arnd

I thought patch 02/10, 'Kernel documentation', would had been first and
met this need?  

Re: [PATCH 04/10] PTI Makefile and Kconfig additions.

[Arnd Bergmann]

On Monday 28 February 2011, J Freyensee wrote:
> On Mon, 2011-02-28 at 10:31 +0100, Arnd Bergmann wrote:
>
> > The Kconfig description is a nice text, how about copying it to the
> > changeset so that reviewers know what the driver is about?
> > 
> 
> I thought patch 02/10, 'Kernel documentation', would had been first and
> met this need?  

Documentation in source files is not the same as documentation in the
changelog, you need both. The changeset comments are usually just one
sentence in your series, and a little more would certainly be helpful.

Also, if you have one changeset with the documentation, that does
not help anyone who looks at another changeset.

	Arnd

Re: [PATCH 04/10] PTI Makefile and Kconfig additions.

[J Freyensee]

On Tue, 2011-03-01 at 12:37 +0100, Arnd Bergmann wrote:
> On Monday 28 February 2011, J Freyensee wrote:
> > On Mon, 2011-02-28 at 10:31 +0100, Arnd Bergmann wrote:
> >
> > > The Kconfig description is a nice text, how about copying it to the
> > > changeset so that reviewers know what the driver is about?
> > > 
> > 
> > I thought patch 02/10, 'Kernel documentation', would had been first and
> > met this need?  
> 
> Documentation in source files is not the same as documentation in the
> changelog, you need both. The changeset comments are usually just one
> sentence in your series, and a little more would certainly be helpful.
> 

Okay, I can do that.

Thanks,
Jay

> Also, if you have one changeset with the documentation, that does
> not help anyone who looks at another changeset.
> 
> 	Arnd