From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
suhail.ahmed@intel.com, christophe.guerard@intel.com
Subject: Re: [PATCH 04/10] PTI Makefile and Kconfig additions.
Date: Tue, 01 Mar 2011 09:37:45 -0800 [thread overview]
Message-ID: <1299001065.3156.35.camel@localhost> (raw)
In-Reply-To: <201103011237.50400.arnd@arndb.de>
On Tue, 2011-03-01 at 12:37 +0100, Arnd Bergmann wrote:
> On Monday 28 February 2011, J Freyensee wrote:
> > On Mon, 2011-02-28 at 10:31 +0100, Arnd Bergmann wrote:
> >
> > > The Kconfig description is a nice text, how about copying it to the
> > > changeset so that reviewers know what the driver is about?
> > >
> >
> > I thought patch 02/10, 'Kernel documentation', would had been first and
> > met this need?
>
> Documentation in source files is not the same as documentation in the
> changelog, you need both. The changeset comments are usually just one
> sentence in your series, and a little more would certainly be helpful.
>
Okay, I can do that.
Thanks,
Jay
> Also, if you have one changeset with the documentation, that does
> not help anyone who looks at another changeset.
>
> Arnd
prev parent reply other threads:[~2011-03-01 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 18:06 [PATCH 04/10] PTI Makefile and Kconfig additions james_p_freyensee
2011-02-28 9:31 ` Arnd Bergmann
2011-02-28 17:49 ` J Freyensee
2011-03-01 11:37 ` Arnd Bergmann
2011-03-01 17:37 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299001065.3156.35.camel@localhost \
--to=james_p_freyensee@linux.intel.com \
--cc=arnd@arndb.de \
--cc=christophe.guerard@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox