From: john stultz <johnstul@us.ibm.com>
To: Torben Hohn <torbenh@gmx.de>
Cc: linux-kernel@vger.kernel.org, richard.cochran@omicron.at,
tglx@linutronix.de
Subject: Re: [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw
Date: Thu, 03 Mar 2011 11:34:04 -0800 [thread overview]
Message-ID: <1299180844.28285.111.camel@work-vm> (raw)
In-Reply-To: <1299173174-348-3-git-send-email-torbenh@gmx.de>
On Thu, 2011-03-03 at 18:26 +0100, Torben Hohn wrote:
> First version of a software clock. Not very useful yet,
> as it doesnt generate events, but at least it allows
> for testing the ptp framework without special hardware.
So in the past, I pushed back on Richard for having something similar,
as I'm not psyched about duplicating interfaces. However, your
implementation is CLOCK_MONOTONIC_RAW instead of CLOCK_REALTIME and it
keeps the adjustments internal, I'm not as opposed.
So I think having such test driver is probably reasonable, but please
make it more explicit that it is just a testing driver, and not
something someone should try to use.
> +
> +struct ixp_clock {
> + struct ptp_clock *ptp_clock;
> + struct ptp_clock_info caps;
> + s64 offset_ns;
> + struct timespec last_timestamp;
> + s32 freq;
> +};
Probably should rename things from ixp_*
thanks
-john
next prev parent reply other threads:[~2011-03-03 19:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 17:26 some patches for the ptp framework Torben Hohn
2011-03-03 17:26 ` [PATCH 1/3] remove __cpuinit from mwait_usable() Torben Hohn
2011-03-03 17:26 ` [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw Torben Hohn
2011-03-03 19:34 ` john stultz [this message]
2011-03-04 6:46 ` Richard Cochran
2011-03-04 11:06 ` torbenh
2011-03-05 20:08 ` john stultz
2011-03-06 13:28 ` Richard Cochran
2011-03-11 11:13 ` torbenh
2011-03-11 11:37 ` Christian Riesch
2011-03-11 13:38 ` torbenh
2011-03-11 11:56 ` Christian Riesch
2011-03-04 6:42 ` Richard Cochran
2011-03-04 11:30 ` torbenh
2011-03-04 16:10 ` Richard Cochran
2011-03-03 17:26 ` [PATCH 3/3] Check for write permission on FD based posix-clocks Torben Hohn
2011-03-04 7:22 ` Richard Cochran
2011-03-04 9:55 ` Arnd Bergmann
2011-03-04 10:13 ` torbenh
2011-03-11 19:46 ` Thomas Gleixner
2011-03-12 17:23 ` Richard Cochran
2011-03-12 17:35 ` Thomas Gleixner
2011-03-12 20:30 ` [tip:timers/core] posix-clocks: Check write permissions in posix syscalls tip-bot for Torben Hohn
2011-03-04 6:21 ` some patches for the ptp framework Richard Cochran
2011-03-10 7:02 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299180844.28285.111.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.cochran@omicron.at \
--cc=tglx@linutronix.de \
--cc=torbenh@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox