From: Namhyung Kim <namhyung@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -tip] x86: correct stack dump info when CONFIG_FRAME_POINTER=y
Date: Fri, 04 Mar 2011 13:00:52 +0900 [thread overview]
Message-ID: <1299211252.1444.9.camel@leonhard> (raw)
In-Reply-To: <20110303164723.GA1807@nowhere>
2011-03-03 (목), 17:47 +0100, Frederic Weisbecker:
> In fact if a caller of dump_trace() passes a stack, it should pass a
> frame pointer as well.
>
> That means we need to revert 9c0729dc8062bed96189bd14ac6d4920f3958743
> ("x86: Eliminate bp argument from the stack tracing routines").
> It would be nice to keep the unified stack_frame() helper out of the revert though,
>
> Would you like to do it?
>
> Thanks.
Of course :) Will send v3.
Thanks.
--
Regards,
Namhyung Kim
prev parent reply other threads:[~2011-03-04 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 17:17 [PATCH -tip] x86: correct stack dump info when CONFIG_FRAME_POINTER=y Namhyung Kim
2011-03-03 11:17 ` [PATCH v2 " Namhyung Kim
2011-03-03 16:47 ` Frederic Weisbecker
2011-03-04 4:00 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299211252.1444.9.camel@leonhard \
--to=namhyung@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox