Re: [PATCH 1/2] MAX8997/8966 MFD: Add IRQ control feature

[Joe Perches <joe@perches.com>]

On Fri, 2011-03-04 at 16:45 +0900, MyungJoo Ham wrote:
> This patch enables IRQ handling for MAX8997/8966 chips.

Just trivial comments.

> +++ b/drivers/mfd/max8997-irq.c
> +static u8 max8997_mask_reg[] = {

static const?

[]

> +static struct max8997_irq_data max8997_irqs[] = {

here too?

> +	[MAX8997_PMICIRQ_PWRONR] = {
> +		.group	= PMIC_INT1,
> +		.mask	= 1 << 0,
> +	},

I think the declaration style is a little hard to
read and verify.  Maybe use a macro something like:

#define DECLARE_IRQ(val, _group, _mask)			\
	[ val ] = { .group = _group, .mask = _mask }

> +	[MAX8997_PMICIRQ_PWRONF] = {
> +		.group	= PMIC_INT1,
> +		.mask	= 1 << 1,
> +	},

So this becomes

	DECLARE_IRQ(MAX8997_PMICIRQ_PWRONR, PMIC_INT1, 1 << 0),
	DECLARE_IRQ(MAX8997_PMICIRQ_PWRONF, PMIC_INT1, 1 << 1),
	etc...

[]

> +static struct irq_chip max8997_irq_chip = {

static const?

> +static irqreturn_t max8997_irq_thread(int irq, void *data)
> +{
> +	struct max8997_dev *max8997 = data;
> +	u8 irq_reg[MAX8997_IRQ_GROUP_NR];
[]
> +	for (i = 0; i < MAX8997_IRQ_GROUP_NR; i++)
> +		irq_reg[i] = 0;

Maybe use a memset or change the declaration to
	u8 irq_reg[MAX8997_IRQ_GROUP_NR] = {};