From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759689Ab1CDOm6 (ORCPT ); Fri, 4 Mar 2011 09:42:58 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:36602 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759426Ab1CDOm5 convert rfc822-to-8bit (ORCPT ); Fri, 4 Mar 2011 09:42:57 -0500 Subject: Re: [PATCH 09/27] nfs: writeback pages wait queue From: Peter Zijlstra To: Wu Fengguang Cc: Andrew Morton , Jan Kara , Jens Axboe , Chris Mason , Trond Myklebust , Christoph Hellwig , Dave Chinner , "Theodore Ts'o" , Mel Gorman , Rik van Riel , KOSAKI Motohiro , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , Balbir Singh , linux-mm , "linux-fsdevel@vger.kernel.org" , LKML In-Reply-To: <20110304143838.GA11504@localhost> References: <20110303064505.718671603@intel.com> <20110303074949.809203319@intel.com> <1299168481.1310.56.camel@laptop> <20110304020157.GB7976@localhost> <1299229843.2428.13484.camel@twins> <1299230795.2428.13486.camel@twins> <20110304143838.GA11504@localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 04 Mar 2011 15:41:13 +0100 Message-ID: <1299249673.24454.5.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-03-04 at 22:38 +0800, Wu Fengguang wrote: > Sorry for being ignorance on the memory barriers.. n/p, everybody who encounters them seems to be a bit confused at first and a lot more confused later :-) > The below patch removes the unnecessary smp_mb__after_clear_bit(). OK, thanks!