From: Mohan Pallaka <mpallaka@codeaurora.org>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Mohan Pallaka <mpallaka@codeaurora.org>
Subject: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations
Date: Mon, 7 Mar 2011 16:39:41 +0530 [thread overview]
Message-ID: <1299496182-26177-2-git-send-email-mpallaka@codeaurora.org> (raw)
In-Reply-To: <1299496182-26177-1-git-send-email-mpallaka@codeaurora.org>
For chip drivers that support both pwm and non-pwm modes
would encounter compilation errors if the platform doesn't
have support for pwm though the chip is programmed to work
in non-pwm mode. Add __weak attributed pwm functions to avoid
compilation issues in these scenarios.
Signed-off-by: Mohan Pallaka <mpallaka@codeaurora.org>
---
include/linux/pwm.h | 21 ++++++++++++++++-----
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 7c77575..3a8c3df 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -3,29 +3,40 @@
struct pwm_device;
+/* Add __weak functions to support PWM */
+
/*
* pwm_request - request a PWM device
*/
-struct pwm_device *pwm_request(int pwm_id, const char *label);
+struct pwm_device __weak *pwm_request(int pwm_id, const char *label)
+{
+ return NULL;
+}
/*
* pwm_free - free a PWM device
*/
-void pwm_free(struct pwm_device *pwm);
+void __weak pwm_free(struct pwm_device *pwm) { }
/*
* pwm_config - change a PWM device configuration
*/
-int pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns);
+int __weak pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns)
+{
+ return -ENODEV;
+}
/*
* pwm_enable - start a PWM output toggling
*/
-int pwm_enable(struct pwm_device *pwm);
+int __weak pwm_enable(struct pwm_device *pwm)
+{
+ return -EINVAL;
+}
/*
* pwm_disable - stop a PWM output toggling
*/
-void pwm_disable(struct pwm_device *pwm);
+void __weak pwm_disable(struct pwm_device *pwm) { }
#endif /* __LINUX_PWM_H */
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-07 11:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 11:09 [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
2011-03-07 11:09 ` Mohan Pallaka [this message]
2011-03-10 12:27 ` [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations Mohan Pallaka
2011-03-07 11:09 ` [PATCH 2/2] input: misc: Add support for isa1200 chip Mohan Pallaka
2011-03-10 12:28 ` Mohan Pallaka
2011-03-21 7:06 ` Trilok Soni
2011-03-24 7:49 ` Dmitry Torokhov
2011-04-06 6:03 ` Mohan Pallaka
2011-03-10 12:23 ` [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 12:25 Mohan Pallaka
2011-04-13 12:25 ` [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations Mohan Pallaka
2011-05-13 12:43 [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
2011-05-13 12:43 ` [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations Mohan Pallaka
2011-05-13 16:25 ` David Brown
2011-05-15 8:00 ` Dmitry Torokhov
2011-05-15 10:58 ` Russell King - ARM Linux
2011-05-17 4:42 ` Mohan Pallaka
2011-05-15 8:16 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299496182-26177-2-git-send-email-mpallaka@codeaurora.org \
--to=mpallaka@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).