public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, "Alek Du" <alek.du@intel.com>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"David Brownell" <dbrownell@users.sourceforge.net>,
	"Eric Miao" <eric.y.miao@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	"Joe Perches" <joe@perches.com>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>,
	"Ryan Mallon" <ryan@bluewatersys.com>
Subject: Re: [PATCH v5 1/4] gpiolib: Add "unknown" direction support
Date: Mon, 07 Mar 2011 18:28:53 -0600	[thread overview]
Message-ID: <1299544133.6057.53.camel@petert> (raw)
In-Reply-To: <20110307065253.GB29999@angua.secretlab.ca>

On Sun, 2011-03-06 at 23:52 -0700, Grant Likely wrote:
> On Sun, Mar 06, 2011 at 08:43:05PM -0600, Peter Tyser wrote:
> > > The thing about gpios is that how they are used is entirely dependant
> > > on what they are wired up to.  There is no avoiding the fact that you
> > > *absolutely* must understand the usage model before even considering
> > > fiddling with a gpio (ignoring the "I wonder what this knob does"
> > > use-case such as when reverse engineer a board).  So, while it is nice
> > > to have an 'unknown' state for sysfs to report, it is certainly not
> > > required.  The model still remains that the pin direction must be set
> > > before (or at the same time as) reading/writing the pin.
> > 
> > As is, even if someone knows about the GPIO wiring on their board, they
> > have to know Linux has a "rule" that "before I can use a GPIO, I have to
> > explicitly set its direction, even if the current reported direction is
> > what I want".  A number of our customers have tried to use a GPIO which
> > states its an 'input' as an input after exporting it, which is
> > completely logical.  But it doesn't work, because its not really an
> > input...  Why not set the direction accurately as 'unknown' so users
> > intuitively know they have to set the direction before using it?  You
> > also mention that it would be a nice feature above, so why not include
> > it?
> 
> I don't like what it does to the implementation, and I'd rather make
> drivers provide accurate data at the outset.

Agreed that ideally drivers should provide accurate data at the outset.
The original patch attempted to move in that direction by making it
optional, and didn't touch the concept of "unknown" directions.  Alan
and others argued we should add support for the "unknown" direction,
which spawned this patch.

To be clear, are you saying you won't accept a patch adding an "unknown"
direction?  Or would you be OK with under circumstance X?  If so, what
is circumstance X?

Best,
Peter


      reply	other threads:[~2011-03-08  0:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 23:28 [PATCH v5 1/4] gpiolib: Add "unknown" direction support Peter Tyser
2011-03-01 23:28 ` [PATCH v5 2/4] gpiolib: Add ability to get GPIO direction Peter Tyser
2011-03-06  7:30   ` Grant Likely
2011-03-07  3:07     ` Peter Tyser
2011-03-07  7:08       ` Grant Likely
2011-03-08  0:38         ` Peter Tyser
2011-03-11 17:48           ` Peter Tyser
2011-03-12  9:18           ` Grant Likely
2011-04-20 22:17             ` Peter Tyser
2011-04-20 22:41               ` Mike Frysinger
2011-03-08 12:13         ` Alan Cox
2011-03-09 22:53           ` Peter Tyser
2011-03-12  9:19             ` Grant Likely
2011-03-01 23:28 ` [PATCH v5 3/4] gpio: pca953x: Implement get_direction() hook Peter Tyser
2011-03-01 23:28 ` [PATCH v5 4/4] gpio: Add support for Intel ICHx/3100/Series[56] GPIO Peter Tyser
2011-04-20 16:35   ` [PATCH v6] " Peter Tyser
2011-05-24 14:18     ` Peter Tyser
2011-05-27  6:42     ` Grant Likely
2011-05-27  9:01       ` Jean Delvare
2011-05-27 14:26         ` Peter Tyser
2011-05-27 20:55           ` Grant Likely
2011-05-27 21:29             ` Peter Tyser
2011-05-27 23:54               ` Grant Likely
2011-05-30 17:27                 ` Peter Tyser
2011-06-03 16:43                   ` Grant Likely
2011-03-06  7:25 ` [PATCH v5 1/4] gpiolib: Add "unknown" direction support Grant Likely
2011-03-06 20:19   ` Ryan Mallon
2011-03-07  2:48     ` Peter Tyser
2011-03-07  6:50     ` Grant Likely
2011-03-07  2:43   ` Peter Tyser
2011-03-07  6:52     ` Grant Likely
2011-03-08  0:28       ` Peter Tyser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299544133.6057.53.camel@petert \
    --to=ptyser@xes-inc.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alek.du@intel.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eric.y.miao@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=joe@perches.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryan@bluewatersys.com \
    --cc=sameo@linux.intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox