public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ivan Djelic <ivan.djelic@parrot.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH/RFC v2 1/3] Shared BCH ECC library
Date: Tue, 08 Mar 2011 14:37:05 +0200	[thread overview]
Message-ID: <1299587825.2754.30.camel@localhost> (raw)
In-Reply-To: <181c9a1c88b781116615761109cccdf89ea877a1.2296641159.git.ivan.djelic@parrot.com>

Well, I can put these to my l2-mtd-2.6 tree and l
On Mon, 2011-02-07 at 15:09 +0100, Ivan Djelic wrote:
>  #
> +# BCH support is selected if needed
> +#
> +# If the BCH library is always used with the same parameters
> +# m and t, you may select option BCH_CONST_PARAMS and provide
> +# default values for symbols BCH_CONST_M and BCH_CONST_T in
> +# your Kconfig code. This will enable extra compiler optimizations
> +# and provide better (up to 2x) encoding performance for small
> +# values of t, at the expense of supporting only a single (m,t)
> +# configuration.
> +#
> +config BCH
> +	tristate
> +
> +config BCH_CONST_PARAMS
> +	boolean
> +
> +config BCH_CONST_M
> +	int
> +	range 5 15
> +
> +config BCH_CONST_T
> +	int

Could you please re-work this and add useful "help" description to each
of these. You added some description to the comments, but it really
should be in the help text instead, may be even in a bit more verbose
form.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


  parent reply	other threads:[~2011-03-08 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 14:09 [PATCH/RFC v2 1/3] Shared BCH ECC library Ivan Djelic
2011-02-07 14:09 ` [PATCH/RFC v2 2/3] mtd: nand: add software BCH ECC support Ivan Djelic
2011-02-07 14:09 ` [PATCH/RFC v2 3/3] mtd: nand: enable software BCH ECC in nand simulator Ivan Djelic
2011-03-08 11:15 ` [PATCH/RFC v2 1/3] Shared BCH ECC library Ivan Djelic
2011-03-08 12:39   ` Artem Bityutskiy
2011-03-08 21:08     ` Thomas Gleixner
2011-03-09 18:02       ` Ivan Djelic
2011-03-08 12:37 ` Artem Bityutskiy [this message]
     [not found] <181c9a1c88b781116615761109cccdf89ea877a1.1296641159.git.ivan.djelic@parrot.com>
2011-02-06 15:03 ` Artem Bityutskiy
2011-02-07 14:16   ` Ivan Djelic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299587825.2754.30.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ivan.djelic@parrot.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox