Re: [PATCH] x86: Fix ACPI wakeup build failure

["Alexander van Heukelum" <heukelum@fastmail.fm>]

On Tue, 08 Mar 2011 22:39 +0100, "Sedat Dilek" <sedat.dilek@googlemail.com> wrote:
> This fixes the following breakage in linux-next (next-20110308):
>   AS      arch/x86/kernel/acpi/wakeup_rm.o
>   arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
>   arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with
>   symbol `wakeup_code_start' does not evaluate to a constant
> 
> The issue was introduced by commit
> d1ee433539ea5963a8f946f3428b335d1c5fdb20:
> "x86, trampoline: Use the unified trampoline setup for ACPI wakeup"
> 
> The problem was discovered while using Debian's binutils
> (2.21.0.20110302-1)
> and experimenting with binutils from upstream.
> 
> Thanks Alexander and H.J. for the vital help.
> 
> CC: Alexander van Heukelum <heukelum@fastmail.fm>
> CC: "H.J. Lu" <hjl.tools@gmail.com>
> CC: Len Brown <len.brown@intel.com>
> CC: Pavel Machek <pavel@ucw.cz>
> CC: "Rafael J. Wysocki" <rjw@sisk.pl>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: x86@kernel.org
> CC: linux-pm@lists.linux-foundation.org
> CC: linux-kernel@vger.kernel.org
> CC: linux-next@vger.kernel.org
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>

Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>

(This problem exists in the x86-tree. Mainline is fine.)

> ---
>  arch/x86/kernel/acpi/wakeup_rm.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/acpi/wakeup_rm.S
> b/arch/x86/kernel/acpi/wakeup_rm.S
> index 6ce81ee..63b8ab5 100644
> --- a/arch/x86/kernel/acpi/wakeup_rm.S
> +++ b/arch/x86/kernel/acpi/wakeup_rm.S
> @@ -9,4 +9,4 @@
>  	.globl	acpi_wakeup_code
>  acpi_wakeup_code:
>  	.incbin	"arch/x86/kernel/acpi/realmode/wakeup.bin"
> -       .size   wakeup_code_start, .-wakeup_code_start
> +       .size   acpi_wakeup_code, .-acpi_wakeup_code
> -- 
> 1.7.4.1
> 
>