Re: [PATCH/RFC v3 1/3] Shared BCH ECC library

[Artem Bityutskiy <dedekind1@gmail.com>]

On Wed, 2011-03-09 at 18:50 +0100, Ivan Djelic wrote:
> Hello,
> 
> The first patch of this series contains a new generic BCH ECC library.
> 
> This library can be used to provide software BCH correction on NAND devices
> (see 2nd and 3rd patch), as well as error correction for hybrid hardware BCH
> engines.
> 
> This version v3
> - improves Kconfig help description as suggested by Artem Bityutskiy
> - documents the public domain origin of a parity computation code snippet
> 
> Could you please review and comment ?
> Thanks,

I've put these patches to my l2-mtd-2.6 tree, let's see if dwmw2 merges
them. I doubt there are many people who'd wish to really review it, but
indeed the code looks good.

There are a couple of checkpatch.pl complaints for the 3rd patch, not
very important though. Also, I think nowadays we do not put file name in
the comments like you did:

+/*
+ * include/linux/bch.h
+ *

But again, not big deal. But it is better to address these tiny things,
anyway. If you re-send v4 - I'll put it to my tree instead of v3.

Thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)