From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768D6C4167B for ; Tue, 5 Dec 2023 12:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345330AbjLEMwx (ORCPT ); Tue, 5 Dec 2023 07:52:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345332AbjLEMwu (ORCPT ); Tue, 5 Dec 2023 07:52:50 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B686191 for ; Tue, 5 Dec 2023 04:52:55 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c9f62fca3bso37362161fa.0 for ; Tue, 05 Dec 2023 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1701780773; x=1702385573; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/6khWfPZUJLhn3k3Km8qMBNnWS1yZtR1UUMcUgVXgbE=; b=RkrrZy4eHDBcJhQOuMWlKJgQkGX8wyiPArC4re/LHLGQAQGIB3z/ag2tdSHQG0GqqP PLALcv5E3RCU7jC61zirPrbfbUeU8trpx1HXpU8Ub4gknVdlumt3XX28AO0ZbV0zwqSa tmae09CRYKt+dH1alWiua3dmCCxit4f8ZPP0IggTTeQNnDWo52WGMqpvBN+NXODCVYn5 qojEA03dAA+/RvvgaxhROBfQe/ptbZjvz2H7Hs6pe9vvjz7h7EvBnLYp9V4w5KZb/qRy sN/EK3qu6jnRtsWuaxsW34HX3LWgFnt+Ndz/LJ+uZA8s5ge5w3DzNTZR1pc+3nhRIwTx V0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701780773; x=1702385573; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/6khWfPZUJLhn3k3Km8qMBNnWS1yZtR1UUMcUgVXgbE=; b=v8oKx6L+xJqNZMEDmtL/toxWqij3L0WMNeImy6QXAZV8G/7kH1TswfE5khUZ6TeCQd QvD7dM1cDsmvWDJG770EDS1lbpmkib+NpggJVgukWLFbV6gtalIDCKW/pjomnsck/JqE 0qbDcpI5VKtXtXsgmQYb0+r26H9fqUWEFdKAk4uctu9zmYXpgi1oodFbYr/51R8fPlxp PIUqfltcEE+sJwSwCr+JcszEQDYJru/TNuF7ydA2X9sGpoiQufkefB8tknQNjkZyVNZa FyHR/PzRtRD4oVLxycp2zjCpyC5tup7m9zREKZKNUKIFwWwhnPXiVjt4jStiqAyTOiJy I/zQ== X-Gm-Message-State: AOJu0Yw51x8M4t6eSgtsbslMV4HsLhC0aAfg+Bi1FU0LkF2wW4Do/UsV 6bMcQGa0v7AzkbSgnLLoj2SOYg== X-Google-Smtp-Source: AGHT+IEaTv9JPYFtY5cztOH3hevOJnMBWMWWpGD6f//fYLRlQTcv4U9qGajlw8lAyC7RdC8q8wP2zQ== X-Received: by 2002:a05:651c:cc:b0:2c9:f0e8:bb5f with SMTP id 12-20020a05651c00cc00b002c9f0e8bb5fmr2841059ljr.40.1701780773336; Tue, 05 Dec 2023 04:52:53 -0800 (PST) Received: from ?IPv6:2804:30c:915:cb00:89a8:6d94:ec55:e0a3? ([2804:30c:915:cb00:89a8:6d94:ec55:e0a3]) by smtp.gmail.com with ESMTPSA id e8-20020a17090ab38800b002801ca4fad2sm4479134pjr.10.2023.12.05.04.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:52:52 -0800 (PST) Message-ID: <12a9ec1bc84dc6d4b461e5c780ba7d3c3aa91740.camel@suse.com> Subject: Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall From: mpdesouza@suse.com To: Shuah Khan , Marcos Paulo de Souza Cc: Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org Date: Tue, 05 Dec 2023 09:52:46 -0300 In-Reply-To: <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org> References: <20231031-send-lp-kselftests-v3-0-2b1655c2605f@suse.com> <20231031-send-lp-kselftests-v3-3-2b1655c2605f@suse.com> <8b95b96c-6aeb-4bf0-8ee9-2ba62330c672@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote: > On 12/1/23 06:13, Marcos Paulo de Souza wrote: > > On Thu, Nov 30, 2023 at 04:24:26PM -0700, Shuah Khan wrote: >=20 > > >=20 > > > Missing module name? Is there a reason to not name this module? > >=20 > > Can you please elaborate? This new module use the same MODULE_ > > macros used by > > the current livepatch selftests. What do you mean by module name? > >=20 >=20 > Pre-commit checpatch script spdx check complained about the module > name. > Please run it to see the message. I've ran checkpatch on all the tree patches, and so far it complained about MAINTANERS file needing to be updated (since we removed lib/livepatch and it's mentioned on MAINTAINERS file): $ ./scripts/checkpatch.pl 000*.patch =20 ----------------------------------------------------------- 0001-kselftests-lib.mk-Add-TEST_GEN_MODS_DIR-variable.patch ----------------------------------------------------------- total: 0 errors, 0 warnings, 68 lines checked 0001-kselftests-lib.mk-Add-TEST_GEN_MODS_DIR-variable.patch has no obvious style problems and is ready for submission. --------------------------------------------------------------- 0002-livepatch-Move-tests-from-lib-livepatch-to-selftests.patch --------------------------------------------------------------- WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #17:=20 debug and rebuild the tests by running make on the selftests/livepatch directory, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #82:=20 rename {lib/livepatch =3D> tools/testing/selftests/livepatch/test_modules}/test_klp_atomic_replace .c (100%) total: 0 errors, 2 warnings, 519 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. 0002-livepatch-Move-tests-from-lib-livepatch-to-selftests.patch has style problems, please review. --------------------------------------------------------------- 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch --------------------------------------------------------------- WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #60:=20 new file mode 100755 total: 0 errors, 1 warnings, 237 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix- inplace. 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. I couldn't find any mention about "missing module name". Is your script showing more warnings than these ones? Can you please share your output? I'll fix MAINTAINERS file but I'll wait until I understand what's missing in your checkpatch script to resend the patchset. Thanks, Marcos=20 >=20 > thanks, > -- Shuah >=20