From: Andrew Lunn <andrew@lunn.ch>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: jackie.jone@alliedtelesis.co.nz, davem@davemloft.net,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
kuba@kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.packham@alliedtelesis.co.nz
Subject: Re: [PATCH] igb: Add MII write support
Date: Thu, 6 Jun 2024 20:31:43 +0200 [thread overview]
Message-ID: <12b1febd-a634-43bb-8edf-79ccb4f9e3aa@lunn.ch> (raw)
In-Reply-To: <c12ffb8e-0606-442b-810a-69bf65624bf9@intel.com>
> Yea, its extremely easy to break things if you don't know what you're
> doing here. So its more a question of "are we ok exposing yet another
> way root can brick things?"
Many MAC drivers allow it, and we have not had complaints. It is not
really something i'm a fan of, it in theory allows user space drivers
for PHYs, but it is full of race conditions so in practice unlikely to
work reliably.
If you are worried about it causing additional support issues because
it gets abused, you could make it taint the kernel. That makes it
clear all bets are off if used. For the use case presented here, a
tainted kernel does not matter, it for lab testing, not production.
Andrew
next prev parent reply other threads:[~2024-06-06 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 3:10 [PATCH] igb: Add MII write support jackie.jone
2024-06-05 20:51 ` Jacob Keller
2024-06-05 21:10 ` Chris Packham
2024-06-05 21:16 ` Jacob Keller
2024-06-05 21:30 ` Chris Packham
2024-06-06 4:30 ` [Intel-wired-lan] " Loktionov, Aleksandr
2024-06-06 15:41 ` Andrew Lunn
2024-06-06 16:56 ` Jacob Keller
2024-06-06 18:31 ` Andrew Lunn [this message]
2024-06-06 18:39 ` Jacob Keller
2024-06-11 11:08 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b1febd-a634-43bb-8edf-79ccb4f9e3aa@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jackie.jone@alliedtelesis.co.nz \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox