public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	Timon Baetz <timon.baetz@protonmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional
Date: Mon, 8 Mar 2021 16:33:44 +0100	[thread overview]
Message-ID: <12c5050f-feb3-e07f-45d2-5e89b678841a@kernel.org> (raw)
In-Reply-To: <20210308152935.2263935-1-arnd@kernel.org>

On 08/03/2021 16:29, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Some of the extcon interfaces have a fallback implementation that can
> be used when EXTCON is disabled, but some others do not, causing a
> build failure:
> 
> drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all' [-Werror,-Wimplicit-function-declaration]
>                 ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev,
>                       ^
> drivers/power/supply/max8997_charger.c:261:9: note: did you mean 'devm_extcon_register_notifier'?
> include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared here
> static inline int devm_extcon_register_notifier(struct device *dev,
> 
> I assume there is no reason to actually build this driver without extcon
> support, so a hard dependency is the easiest fix. Alternatively the
> header file could be extended to provide additional inline stubs.

Hi Arnd,

Thanks for the patch but I think I got it covered with:
https://lore.kernel.org/lkml/20210215100610.19911-2-cw00.choi@samsung.com/
(sent via extcon tree).

Did you experience a new/different issue?

Best regards,
Krzysztof

  reply	other threads:[~2021-03-08 15:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 15:29 [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional Arnd Bergmann
2021-03-08 15:33 ` Krzysztof Kozlowski [this message]
2021-03-08 16:02   ` Arnd Bergmann
2021-03-08 16:11     ` Krzysztof Kozlowski
2021-03-09 10:11       ` Chanwoo Choi
2021-03-08 15:50 ` Matti Vaittinen
2021-03-08 16:07   ` Arnd Bergmann
2021-03-08 16:06 ` Andy Shevchenko
2021-03-08 16:10   ` Andy Shevchenko
2021-03-08 16:31   ` Vaittinen, Matti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c5050f-feb3-e07f-45d2-5e89b678841a@kernel.org \
    --to=krzk@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=sre@kernel.org \
    --cc=timon.baetz@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox