Re: 2.6.14-rc1 breaks tg3 on ia64

John W. Linville
2005-09-17T16:47:16Z

On Sat, Sep 17, 2005 at 09:16:17AM -0700, Greg KH wrote:
> On Sat, Sep 17, 2005 at 11:59:14AM -0400, John W. Linville wrote:
> > On Sat, Sep 17, 2005 at 08:47:03AM -0700, Tony Luck wrote:

> > > Anyone know anything more about this problem? I'm not seeing it
> > > on any of my systems ... so perhaps it only affects cards with a
> > > PCI bridge on them, or cards that haven't already been initialized
> > > by EFI.
> >
> > I posted a patch on Wednesday:
> >
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0509.1/2193.html
> >
> > The original reporter (Keith Owens <kaos@sgi.com>) confirmed this
> > patch to fix the problem.
>
> Yes, and a number of people objected to that patch. Care to respond to
> them?

Care to check your email? :-)

http://www.ussg.iu.edu/hypermail/linux/kernel/0509.1/2267.html

Basically, the concerns raised are non-issues. The new patch
merely limits the BAR restoration to those situations where it is
truly needed. Anything broken in that situation was broken before
the original patch as well.

The only other point was that this particular ia64 hardware is
broken if you can't rewrite its BARs. That may well be, but we can
accomodate it w/o losing the intent of the original patch.

Tony's post indicates that this is not a generic ia64 problem. If you
want a patch along the lines of what Dave Miller and Ivan Kokshaysky
advocate (i.e. something in the pci access routines for this box),
then Keith or someone else w/ knowledge of (and access to) this box
will need to step forward w/ a patch or at least some information.

John
--
John W. Linville
linville@tuxdriver.com