From: Florian Fainelli <f.fainelli@gmail.com>
To: Aleksander Jan Bajkowski <olek2@wp.pl>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, jacob.e.keller@intel.com,
john@phrozen.org, ralf@linux-mips.org, ralph.hempel@lantiq.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 1/1] net: ethernet: lantiq_etop: fix memory disclosure
Date: Mon, 23 Sep 2024 15:22:46 -0700 [thread overview]
Message-ID: <12e5cb65-28a5-4f43-bf54-437e6141811a@gmail.com> (raw)
In-Reply-To: <20240923214949.231511-2-olek2@wp.pl>
On 9/23/24 14:49, Aleksander Jan Bajkowski wrote:
> When applying padding, the buffer is not zeroed, which results in memory
> disclosure. The mentioned data is observed on the wire. This patch uses
> skb_put_padto() to pad Ethernet frames properly. The mentioned function
> zeroes the expanded buffer.
>
> In case the packet cannot be padded it is silently dropped. Statistics
> are also not incremented. This driver does not support statistics in the
> old 32-bit format or the new 64-bit format. These will be added in the
> future. In its current form, the patch should be easily backported to
> stable versions.
>
> Ethernet MACs on Amazon-SE and Danube cannot do padding of the packets
> in hardware, so software padding must be applied.
>
> Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks for taking in the suggsetion!
--
Florian
next prev parent reply other threads:[~2024-09-23 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 21:49 [PATCH net v3 0/1] net: ethernet: lantiq_etop: fix memory disclosure Aleksander Jan Bajkowski
2024-09-23 21:49 ` [PATCH net v3 1/1] " Aleksander Jan Bajkowski
2024-09-23 21:54 ` Keller, Jacob E
2024-09-23 22:22 ` Florian Fainelli [this message]
2024-10-01 8:57 ` Paolo Abeni
2024-10-01 9:00 ` [PATCH net v3 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e5cb65-28a5-4f43-bf54-437e6141811a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox